1804853 - build failure on OpenBSD since bug 1530373 (trait bound `Device: HIDDevice` is not satisfied)

Status: VERIFIED FIXED

(Core :: DOM: Web Authentication, defect)

Description

[Landry Breuil (:gaston)]

m-c blows for me on OpenBSD/amd64 since bug 1530373 landed, cf full log at http://buildbot.rhaalovely.net/nine/#/builders/3/builds/1524/steps/8/logs/stdio

 3:00.82 error[E0277]: the trait bound `Device: HIDDevice` is not satisfied
 3:00.82    --> /build/buildslave-amd64/mozilla-central-amd64/build/third_party/rust/authenticator/src/statemachine.rs:306:5
 3:00.82     |
 3:00.82 306 | /     fn init_and_select(
 3:00.82 307 | |         info: DeviceBuildParameters,
 3:00.82 308 | |         selector: &Sender<DeviceSelectorEvent>,
 3:00.82 309 | |         ctap2_only: bool,
 3:00.82 ...   |
 3:00.82 381 | |         Some(dev)
 3:00.82 382 | |     }
 3:00.82     | |_____^ the trait `HIDDevice` is not implemented for `Device`
 3:00.97 error[E0277]: the trait bound `Device: HIDDevice` is not satisfied
 3:00.97   --> /build/buildslave-amd64/mozilla-central-amd64/build/third_party/rust/authenticator/src/transport/device_selector.rs:32:18
 3:00.97    |
 3:00.97 32 |     DevicesAdded(Vec<DeviceID>),
 3:00.97    |                  ^^^^^^^^^^^^^ the trait `HIDDevice` is not implemented for `Device`
 3:00.98 error[E0277]: the trait bound `Device: HIDDevice` is not satisfied in `DeviceSelectorEvent`
 3:00.98   --> /build/buildslave-amd64/mozilla-central-amd64/build/third_party/rust/authenticator/src/transport/device_selector.rs:41:13
 3:00.98    |
 3:00.98 41 |     sender: Sender<DeviceSelectorEvent>,
 3:00.98    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ within `DeviceSelectorEvent`, the trait `HIDDevice` is not implemented for `Device`
 3:00.98    |
 3:00.98 note: required because it appears within the type `DeviceSelectorEvent`
 3:00.98   --> /build/buildslave-amd64/mozilla-central-amd64/build/third_party/rust/authenticator/src/transport/device_selector.rs:29:10
 3:00.98    |
 3:00.98 29 | pub enum DeviceSelectorEvent {
 3:00.98    |          ^^^^^^^^^^^^^^^^^^^
 3:00.98 note: required by a bound in `Sender`
 3:00.98 error[E0277]: the trait bound `Device: HIDDevice` is not satisfied in `DeviceSelectorEvent`
 3:00.98    --> /build/buildslave-amd64/mozilla-central-amd64/build/third_party/rust/authenticator/src/transport/device_selector.rs:184:35
 3:00.98     |
 3:00.98 184 |     pub fn clone_sender(&self) -> Sender<DeviceSelectorEvent> {
 3:00.98     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^ within `DeviceSelectorEvent`, the trait `HIDDevice` is not implemented for `Device`
 3:00.98     |
 3:00.98 note: required because it appears within the type `DeviceSelectorEvent`
 3:00.98    --> /build/buildslave-amd64/mozilla-central-amd64/build/third_party/rust/authenticator/src/transport/device_selector.rs:29:10
 3:00.98     |
 3:00.98 29  | pub enum DeviceSelectorEvent {
 3:00.98     |          ^^^^^^^^^^^^^^^^^^^
 3:00.98 note: required by a bound in `Sender`
 3:00.98 error[E0277]: the trait bound `Device: HIDDevice` is not satisfied
 3:00.98    --> /build/buildslave-amd64/mozilla-central-amd64/build/third_party/rust/authenticator/src/transport/device_selector.rs:188:5
 3:00.98     |
 3:00.98 188 | /     fn cancel_all(tokens: HashMap<Device, Sender<DeviceCommand>>, exclude: Option<&DeviceID>) {
 3:00.98 189 | |         tokens
 3:00.98 190 | |             .into_keys()
 3:00.98 191 | |             .filter(|x| exclude.map_or(true, |y| y != &x.id()))
 3:00.98 192 | |             .for_each(|mut dev| dev.cancel().unwrap()); // TODO
 3:00.98 193 | |     }
 3:00.98     | |_____^ the trait `HIDDevice` is not implemented for `Device`
 3:01.08 For more information about this error, try `rustc --explain E0277`.
 3:01.17 error: could not compile `authenticator` due to 5 previous errors
 3:01.17 warning: build failed, waiting for other jobs to finish...

i've tried a clean build of m-c to make sure it wasnt an objdir pollution but it failed the same.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1530373

:jschanck, since you are the author of the regressor, bug 1530373, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[John Schanck [:jschanck]]

msirringhaus: can you take a look?

Comment 3

[Landry Breuil (:gaston)]

this now affects beta since m-c was merged there... sigh.

Comment 4

[msirringhaus]

I'm working on a build-fix now. But I can't promise it will work during runtime, as I don't have deep knowledge of how openBSD (or the other BSD-flavors) does things.
But it should buy us enough time to work this out, as that side of the code is currently not used (and can, for a while, be switched off, if Firefox activates it again by default).

Comment 5

[Landry Breuil (:gaston)]

(In reply to msirringhaus from comment #4)

I'm working on a build-fix now. But I can't promise it will work during runtime, as I don't have deep knowledge of how openBSD (or the other BSD-flavors) does things.

runtime isnt my worry for now as i dont have u2f hw to test and i doubt the low-level bits will work on openbsd straight away, but to me that's a rather small usecase. right now my worry is having m-c and m-b in a buildable state :)

But it should buy us enough time to work this out, as that side of the code is currently not used (and can, for a while, be switched off, if Firefox activates it again by default).

good to know !

available to test a diff when you have one :)

Comment 6

[msirringhaus]

Could you try out https://github.com/mozilla/authenticator-rs/pull/211 ?

Comment 7

[Landry Breuil (:gaston)]

(In reply to msirringhaus from comment #6)

Could you try out https://github.com/mozilla/authenticator-rs/pull/211 ?

m-c seems to build further with the PR applied onthird_party/rust/authenticator - will do more build tests when i build 109.0b1.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1530373

Comment 9

[Landry Breuil (:gaston)]

havent checked runtime yet, but backporting the current state of https://github.com/mozilla/authenticator-rs/pull/211 allows me to apparently build 109.0b1 - at least all the rust bits seem to build.

Comment 10

[Landry Breuil (:gaston)]

Chris, Ryo, you might be interested in testing this for FreeBSD/NetBSD builds. Cf https://github.com/mozilla/authenticator-rs/pull/211#issuecomment-1349587974

Comment 11

[John Schanck [:jschanck]]

Attachment: Bug 1804853 - upgrade to authenticator 0.4.0-alpha.5. r=#supply-chain-reviewers

Version 0.4.0-alpha.5 fixes build errors on OpenBSD, NetBSD, and FreeBSD.

Comment 12

[John Schanck [:jschanck]]

Landry, can you please confirm that M-C builds with the attached patch. Thanks!

Comment 13

[John Schanck [:jschanck]]

Attachment: Bug 1804853 - upgrade to authenticator 0.4.0-alpha.6. r=#supply-chain-reviewers

Version 0.4.0-alpha.6 fixes build errors on OpenBSD, NetBSD, and FreeBSD
that were present in 0.4.0-alpha.4, and fixes a build error on Android
that was introduced in 0.4.0-alpha.5.

Comment 14

[Landry Breuil (:gaston)]

(In reply to John Schanck [:jschanck] from comment #12)

Landry, can you please confirm that M-C builds with the attached patch. Thanks!

109.0b2 builds fine on OpenBSD/amd64 with the latest iteration of the patch on phabricator (eg 0.4.0-alpha.6)

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb872d1db370
upgrade to authenticator 0.4.0-alpha.6. r=supply-chain-reviewers

Comment 16

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bb872d1db370

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jschanck, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 18

[John Schanck [:jschanck]]

Comment on attachment 9308433 [details]
Bug 1804853 - upgrade to authenticator 0.4.0-alpha.6. r=#supply-chain-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Firefox will not build on OpenBSD.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The code is pref'd off by default in beta, so there is no functional change at run time.
• String changes made/needed:
• Is Android affected?: No

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9308433 [details]
Bug 1804853 - upgrade to authenticator 0.4.0-alpha.6. r=#supply-chain-reviewers

Approved for 109.0b4.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a91b374c129b

Comment 21

[Landry Breuil (:gaston)]

thanks a lot, m-b and m-c build fine unpatched again.

• http://buildbot.rhaalovely.net/nine/#/builders/2/builds/1503
• http://buildbot.rhaalovely.net/nine/#/builders/3/builds/1536