1804872 - reddit recap animation looks bad

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Timothy Nikkel (:tnikkel)]

Attachment: Screen Recording 2022-12-09 at 5.15.43 AM.mov

Goto https://old.reddit.com/RedditRecap2022 as a logged in user and scroll down.

I think this is probably a dupe of one of the open ChooseScale bugs.

Comment 1

[Sotaro Ikeda [:sotaro]]

(In reply to Timothy Nikkel (:tnikkel) from comment #0)

I think this is probably a dupe of one of the open ChooseScale bugs.

:tnikkel, is there a list of the bugs?

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1804872. Handle cases where a scale animation is being run on the compositor when choosing the size to get a decoded image at. r=aosmond

The transform on the stacking context helper has the current scale, not the largest scale of the animation. The scale on the stack context helper holds this value thanks to the logic in ChooseScale.

Before webrender we would just look at the current matrix on the gfx context so it would have final size to draw at for the animation.

I have a fix that also fixes the blob recordings/image region case but it is a little more invasive so I want to land this first. The 3rd reftest will ensure that we can't turn on blob recording without fixing that case.

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: rra.html

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f53842753805
Handle cases where a scale animation is being run on the compositor when choosing the size to get a decoded image at. r=aosmond

Comment 5

[Iulian Moraru]

Backed out for causing reftest failures on 1553571-1.html.

• Push with failures

• Failure log

• Backout link

Comment 6

[Timothy Nikkel (:tnikkel)]

1553571-1.html uses a 1px x 1px div with a 256px x 256px image and uses a scale to scale it up to 140px, and then keeps tweaking the scale by a random factor of 0.01 to keep it as an active layer tracker actively scaled element.

This code

https://searchfox.org/mozilla-central/rev/ee6ab6eb2d222e0004604de62206baa67cac33af/gfx/layers/wr/StackingContextHelper.cpp#80

scales us up to the next power of 2 because for javascript controlled scale animations we don't know what scale to choose so we just round up to the the factor of 2. The patch in this bug means we actually decode at 256 x 256 (like the choosen scale is asking for) instead of ignoring that scale and decoding at 140 x 140.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7cdf4e16226
Handle cases where a scale animation is being run on the compositor when choosing the size to get a decoded image at. r=aosmond

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e7cdf4e16226