1804877 - Set XDG_ACTIVATION_TOKEN when launch external application (LaunchWithURI)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

Follow up from Bug 1767546. We should set XDG_ACTIVATION_TOKEN when external app is fired to make sure it gets focus.

Especially useful for Thunderbird when URL is opened by Firefox.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1804877 [Linux] Don't log redundant window boundaries r?emilio

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1804877 [Wayland] Implement xdg_activation by WidgetUtilsGtk r?emilio

Implement RequestWaylandFocus() which returns FocusRequestPromise.
It resolves to XDG token which can be used to activate Firefox window or transfered to another application.

Also use 0.5 sec timeout to reject FocusRequestPromise to make sure we don't wait forever in case of Wayland compositor bug or so.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1804877 [Wayland] Rename nsWindow::RequestFocusWaylandWindow to nsWindow::TransferFocusToWaylandWindow() and use FocusWaylandWindow() there r?emilio

Depends on D165150

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1804877 [Wayland] Use RequestWaylandFocus()/XDG token in nsGIOService to launch external applications r?emilio

Depends on D165151

Comment 5

[Martin Stránský [:stransky] (ni? me)]

https://gitlab.gnome.org/GNOME/glib/-/issues/2709 may be related.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11d72eaa9cd9
[Linux] Don't log redundant window boundaries r=emilio

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6f5a91e18da
[Wayland] Implement xdg_activation by WidgetUtilsGtk r=emilio
https://hg.mozilla.org/integration/autoland/rev/800f78104e83
[Wayland] Rename nsWindow::RequestFocusWaylandWindow to nsWindow::TransferFocusToWaylandWindow() and use FocusWaylandWindow() there r=emilio
https://hg.mozilla.org/integration/autoland/rev/0f042a90a90b
[Wayland] Use RequestWaylandFocus()/XDG token in nsGIOService to launch external applications r=emilio

Comment 8

[Iulian Moraru]

Backed out for causing multiple build bustages.

Push with failures

Failure log for bp-hybrid bustage on WidgetUtilsGtk.cpp
Failure log for bx bustage on nsGIOService.cpp

Backout link

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ccb5417b450
[Wayland] Implement xdg_activation by WidgetUtilsGtk r=emilio
https://hg.mozilla.org/integration/autoland/rev/8334a7ab8797
[Wayland] Rename nsWindow::RequestFocusWaylandWindow to nsWindow::TransferFocusToWaylandWindow() and use FocusWaylandWindow() there r=emilio
https://hg.mozilla.org/integration/autoland/rev/c5f40da7312a
[Wayland] Use RequestWaylandFocus()/XDG token in nsGIOService to launch external applications r=emilio

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/11d72eaa9cd9

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3ccb5417b450
https://hg.mozilla.org/mozilla-central/rev/8334a7ab8797
https://hg.mozilla.org/mozilla-central/rev/c5f40da7312a