NumLock deactivated in the date input field when using the keyboard number pad from the right side
Categories
(Firefox :: Keyboard Navigation, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox107 | --- | unaffected |
firefox108 | --- | unaffected |
firefox109 | --- | verified |
firefox110 | --- | verified |
People
(Reporter: epopescu, Assigned: ayeddi)
References
(Regressed 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Found in
- Firefox Nightly 109.0a1
Affected versions
- Firefox Nightly 109.0a1
Tested platforms
- Affected platforms: Windows 10, Ubuntu 22.04
- Unaffected platforms: macOS 13
Preconditions
- Firefox Nightly installed
Steps to reproduce
- Reach data:text/html, <input type='date'>
- Hit TAB to reach the date input field(or use mouse to click inside the field)
- Use keyboard number pad from the right side to type any month/day/year(press 2)
Expected result
- You should be able to type in the date input field using the keyboard number pad from the right side.
Actual result
- NumLock is deactivated once we reach the date input field and nothing can be typed in using the keyboard number pad from the right side.
Regression range
- Last good revision: 99052dd249cc79a752aeed699b8cb4633f3d2cd9
- First bad revision: fe7d9416e64121a3e2b356311b669f2a53052e7b
- Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=99052dd249cc79a752aeed699b8cb4633f3d2cd9&tochange=fe7d9416e64121a3e2b356311b669f2a53052e7b - Potentially regressed by: Bug 1676068
Additional notes
- This issue is noticeable on other date input fields such as this one data:text/html, <input type='date'>:
data:text/html,<input type='datetime-local'>
https://carmacleod.github.io/playground/value-attr-tests.html
http://research.coolfields.co.uk/forms/html5-date.html
Reporter | ||
Updated•1 year ago
|
Updated•1 year ago
|
Comment 1•1 year ago
|
||
:ayeddi, since you are the author of the regressor, bug 1676068, could you take a look?
For more information, please visit auto_nag documentation.
Updated•1 year ago
|
Assignee | ||
Comment 2•1 year ago
|
||
Resolving a regression caused by the bug 1676068 where NumLock state is inverted for <input type=date>
, <input type=time>
, and <input type=datetime-local>
input boxes.
The code removed was introduced as a remediation to the bug 1314544 with the keyCode
attribute used which was since deprecated.
Updated•1 year ago
|
Comment 3•1 year ago
|
||
Set release status flags based on info from the regressing bug 1676068
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff2453971925 DateTimeInput to support NumLock keys. r=Jamie,mconley
Assignee | ||
Updated•1 year ago
|
Comment 5•1 year ago
|
||
bugherder |
Comment 6•1 year ago
|
||
The patch landed in nightly and beta is affected.
:ayeddi, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox109
towontfix
.
For more information, please visit auto_nag documentation.
Reporter | ||
Comment 7•1 year ago
|
||
Verified as fixed on Nightly 110.0a1 (2022-12-14) on Windows 10, maOS 11 and Ubuntu 22.04.
Assignee | ||
Comment 8•1 year ago
|
||
(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #6)
The patch landed in nightly and beta is affected.
:ayeddi, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox109
towontfix
.For more information, please visit auto_nag documentation.
Hi :RyanVM, could we nominate this patch to be uplifted to Beta 109 as part 1 of 2 Datepicker's (bug 1676068) issues that are to be resolved by the next week? We can also wait with the uplifting itself until the destiny of the datepicker patch is decided (mind you I am yet to fix the remaining bug 1804559 with scrolling on Wayland/Linux).
Comment 9•1 year ago
|
||
Go ahead and nominate it now, but I'll sit on it until we decide which way we want to go.
Assignee | ||
Comment 11•1 year ago
|
||
Comment on attachment 9307921 [details]
Bug 1804881 - DateTimeInput to support NumLock keys. r=Jamie,mconley!
Beta/Release Uplift Approval Request
- User impact if declined: Currently the use of NumLock is reversed for the date/datetime-local inputs because of the updated datepicker code and this patch is fixing it
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: (it was confirmed fixed in Nightly by the QA team)
STR are provided in the bug - List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Low risk because it updates a few lines of JavaScript code removing an unnecessary conditional that gets the Numlock use limited. The patch also introduces test coverage for actual keyboard input on the date/datetime-local inputs which were lacking before (thus the bug slipped through as a regression)
- String changes made/needed: none
- Is Android affected?: No
Assignee | ||
Updated•1 year ago
|
Updated•1 year ago
|
Comment 12•1 year ago
|
||
Comment on attachment 9307921 [details]
Bug 1804881 - DateTimeInput to support NumLock keys. r=Jamie,mconley!
Approved for 109.0b4.
Comment 13•1 year ago
|
||
bugherder uplift |
Reporter | ||
Comment 14•1 year ago
|
||
Verified as fixed on Firefox 109.0b4 on Windows 10, maOS 11 and Ubuntu 22.04.
Description
•