1804894 - attribution code is attempted to be written to the install directory for msix builds

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P2)

Description

[[e-mail] (:bhearsum)]

...which obviously won't work, because the directory is not writable.

The error, from a recent browser-chrome run:
[task 2022-12-09T00:10:22.073Z] 00:10:22 INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_attribution.js | Uncaught exception in test - NotAllowedError: Could not open the file at C:\Program Files\WindowsApps\Mozilla.MozillaFirefoxNightly_109.2212.820.0_x64__5x4grbbqzn2q4\VFS\ProgramFiles\MozillaFirefoxNightly Package Root\postSigningData for writing

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Bug 1804894: Don't write postSigningData in MSIX builds r?nalexander!

This is only done by the Return-to-AMO flow, which is not supported in MSIX anyways.

Also, disable the RTAMO test for MSIX builds while we're here.

Depends on D164665

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07d62af0767f
Don't write postSigningData in MSIX builds r=nalexander

Comment 3

[Iulian Moraru]

Backed out for breaking gecko decision task.

Push with failures

Failure log

Backout link

<...>
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/moztest/moztest/resolve.py", line 548, in __call__
[task 2022-12-15T00:49:54.351Z]     tests = self._load_manifestparser_manifest(mpath)
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/moztest/moztest/resolve.py", line 519, in _load_manifestparser_manifest
[task 2022-12-15T00:49:54.351Z]     mp = TestManifest(
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 824, in __init__
[task 2022-12-15T00:49:54.351Z]     ManifestParser.__init__(self, *args, **kwargs)
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 97, in __init__
[task 2022-12-15T00:49:54.351Z]     self.read(*manifests)
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 292, in read
[task 2022-12-15T00:49:54.351Z]     self._read(here, filename, defaults)
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 181, in _read
[task 2022-12-15T00:49:54.351Z]     sections, defaults = read_ini(
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/manifestparser/manifestparser/ini.py", line 140, in read_ini
[task 2022-12-15T00:49:54.351Z]     assert (
[task 2022-12-15T00:49:54.351Z] AssertionError: Found duplicate key skip-if in section DEFAULT
[task 2022-12-15T00:49:54.351Z] Traceback (most recent call last):
[task 2022-12-15T00:49:54.352Z]   File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 244, in taskgraph_decision
[task 2022-12-15T00:49:54.352Z]     ret = taskgraph_commands["decision"].func(options)
[task 2022-12-15T00:49:54.352Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/main.py", line 633, in decision
[task 2022-12-15T00:49:54.352Z]     taskgraph_decision(options)
[task 2022-12-15T00:49:54.352Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/decision.py", line 235, in taskgraph_decision
[task 2022-12-15T00:49:54.352Z]     full_task_json = tgg.full_task_graph.to_json()
[task 2022-12-15T00:49:54.352Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 169, in full_task_graph
[task 2022-12-15T00:49:54.352Z]     return self._run_until("full_task_graph")
[task 2022-12-15T00:49:54.352Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 423, in _run_until
[task 2022-12-15T00:49:54.352Z]     k, v = next(self._run)
[task 2022-12-15T00:49:54.352Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 309, in _run
[task 2022-12-15T00:49:54.352Z]     new_tasks = kind.load_tasks(
<...>

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/781c9baafa7d
Don't write postSigningData in MSIX builds r=nalexander

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/781c9baafa7d