1804895 - [Hulu] The key shortcut for mute/unmute a PiP video is not working accordingly

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Alin Ilea, Desktop QA]

Found in

• 109.0a1

Affected versions

• 107.0.1, 108.0, 109.0a1 (2022-12-09)

Tested platforms

• Affected platforms: Windows 10, macOS 12, Ubuntu 20.

Steps to reproduce

1. Access the following website: https://www.hulu.com/
2. Play any video and open the PiP window.
3. Press ctrl + up arrow twice or ctrl + down arrow twice.

Expected result

• ctrl + up arrow should unmute the PiP video and ctrl + down arrow should mute the PiP video (this is what the mute/unmute pip icon tooltip says and this is the behavior on e.g youtube). ctrl + up arrow should not mute the video and ctrl + down arrow should not unmute the video.

Actual result

• Both combinations (ctrl + up arrow and ctrl + down arrow) can mute and unmute the PiP video.

Regression range

• Not a regression.

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1804895 - Update setMuted method for Hulu video wrapper to only toggle when setting a new muted state. r=#pip-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa3c02de56dc
Update setMuted method for Hulu video wrapper to only toggle when setting a new muted state. r=pip-reviewers,mhowell

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fa3c02de56dc

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Nightly 110.0a1 (2022-12-16) using Windows 10, macOS 12 and Ubuntu 20.