Closed Bug 1804899 Opened 2 years ago Closed 2 years ago

browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js fails against MSIX packages

Categories

(Firefox :: Messaging System, defect, P2)

defect

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

(Whiteboard: [fidedi-ope])

Attachments

(1 file)

[task 2022-12-09T00:11:51.538Z] 00:11:51 INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js | Uncaught exception in test - at resource://testing-common/sinon-7.2.7.js:3605 - TypeError: Attempted to wrap getAddonsByIDs which is already wrapped
[task 2022-12-09T00:11:51.538Z] 00:11:51 INFO - Stack trace:
[task 2022-12-09T00:11:51.538Z] 00:11:51 INFO - checkWrappedMethod@resource://testing-common/sinon-7.2.7.js:3605:21
[task 2022-12-09T00:11:51.538Z] 00:11:51 INFO - wrapMethod@resource://testing-common/sinon-7.2.7.js:3653:31
[task 2022-12-09T00:11:51.538Z] 00:11:51 INFO - stub@resource://testing-common/sinon-7.2.7.js:3002:44
[task 2022-12-09T00:11:51.538Z] 00:11:51 INFO - stub@resource://testing-common/sinon-7.2.7.js:2099:33
[task 2022-12-09T00:11:51.539Z] 00:11:51 INFO - test_rtamo_aboutwelcome@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js:126:11
[task 2022-12-09T00:11:51.539Z] 00:11:51 INFO - handleTask@chrome://mochikit/content/browser-test.js:1037:26
[task 2022-12-09T00:11:51.539Z] 00:11:51 INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1109:18
[task 2022-12-09T00:11:51.539Z] 00:11:51 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1244:14
[task 2022-12-09T00:11:51.539Z] 00:11:51 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1026:14
[task 2022-12-09T00:11:51.539Z] 00:11:51 INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1036:13
[task 2022-12-09T00:11:51.540Z] 00:11:51 INFO -
[task 2022-12-09T00:11:51.540Z] 00:11:51 INFO - --------------
[task 2022-12-09T00:11:51.540Z] 00:11:51 INFO - wrapMethod@resource://testing-common/sinon-7.2.7.js:3679:26
[task 2022-12-09T00:11:51.540Z] 00:11:51 INFO - stub@resource://testing-common/sinon-7.2.7.js:3002:44
[task 2022-12-09T00:11:51.540Z] 00:11:51 INFO - stub@resource://testing-common/sinon-7.2.7.js:2099:33
[task 2022-12-09T00:11:51.540Z] 00:11:51 INFO - openRTAMOWithAttribution@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_attribution.js:68:11
[task 2022-12-09T00:11:51.540Z] 00:11:51 INFO - test_rtamo_attribution@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_aboutwelcome_attribution.js:129:23
[task 2022-12-09T00:11:51.540Z] 00:11:51 INFO - handleTask@chrome://mochikit/content/browser-test.js:1037:26
[task 2022-12-09T00:11:51.540Z] 00:11:51 INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1109:18
[task 2022-12-09T00:11:51.540Z] 00:11:51 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1244:14
[task 2022-12-09T00:11:51.540Z] 00:11:51 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1026:14
[task 2022-12-09T00:11:51.540Z] 00:11:51 INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1036:13
[task 2022-12-09T00:11:51.541Z] 00:11:51 INFO - Leaving test bound test_rtamo_aboutwelcome
[task 2022-12-09T00:11:51.542Z] 00:11:51 INFO - Entering test bound test_rtamo_over_experiments
[task 2022-12-09T00:11:51.542Z] 00:11:51 INFO - Not taking screenshot here: see the one that was previously logged

The right thing to do here might just be disabling the test, since the RTAMO flow isn't supported for MSIX packages. The error should probably be investigated first though - it's possible there's a real underlying issues that we ought to fix.

Assignee: nobody → bhearsum
Severity: -- → S3
Priority: -- → P2
Whiteboard: [fidedi-ope]

Return-to-AMO is not supported in MSIX builds (yet, anyways) - and this test fails when run against them.

Depends on D164668

See Also: → 1784121
Pushed by bhearsum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/140f75f3f919 browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js fails against MSIX packages r=pdahiya

Backed out for breaking gecko decision task.

Push with failures

Failure log

Backout link

<...>
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/moztest/moztest/resolve.py", line 548, in __call__
[task 2022-12-15T00:49:54.351Z]     tests = self._load_manifestparser_manifest(mpath)
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/moztest/moztest/resolve.py", line 519, in _load_manifestparser_manifest
[task 2022-12-15T00:49:54.351Z]     mp = TestManifest(
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 824, in __init__
[task 2022-12-15T00:49:54.351Z]     ManifestParser.__init__(self, *args, **kwargs)
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 97, in __init__
[task 2022-12-15T00:49:54.351Z]     self.read(*manifests)
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 292, in read
[task 2022-12-15T00:49:54.351Z]     self._read(here, filename, defaults)
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/manifestparser/manifestparser/manifestparser.py", line 181, in _read
[task 2022-12-15T00:49:54.351Z]     sections, defaults = read_ini(
[task 2022-12-15T00:49:54.351Z]   File "/builds/worker/checkouts/gecko/testing/mozbase/manifestparser/manifestparser/ini.py", line 140, in read_ini
[task 2022-12-15T00:49:54.351Z]     assert (
[task 2022-12-15T00:49:54.351Z] AssertionError: Found duplicate key skip-if in section DEFAULT
[task 2022-12-15T00:49:54.351Z] Traceback (most recent call last):
[task 2022-12-15T00:49:54.352Z]   File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 244, in taskgraph_decision
[task 2022-12-15T00:49:54.352Z]     ret = taskgraph_commands["decision"].func(options)
[task 2022-12-15T00:49:54.352Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/main.py", line 633, in decision
[task 2022-12-15T00:49:54.352Z]     taskgraph_decision(options)
[task 2022-12-15T00:49:54.352Z]   File "/builds/worker/checkouts/gecko/taskcluster/gecko_taskgraph/decision.py", line 235, in taskgraph_decision
[task 2022-12-15T00:49:54.352Z]     full_task_json = tgg.full_task_graph.to_json()
[task 2022-12-15T00:49:54.352Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 169, in full_task_graph
[task 2022-12-15T00:49:54.352Z]     return self._run_until("full_task_graph")
[task 2022-12-15T00:49:54.352Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 423, in _run_until
[task 2022-12-15T00:49:54.352Z]     k, v = next(self._run)
[task 2022-12-15T00:49:54.352Z]   File "/builds/worker/checkouts/gecko/third_party/python/taskcluster_taskgraph/taskgraph/generator.py", line 309, in _run
[task 2022-12-15T00:49:54.352Z]     new_tasks = kind.load_tasks(
<...>
Flags: needinfo?(bhearsum)
Pushed by bhearsum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/472f4286fa2f browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js fails against MSIX packages r=pdahiya
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Flags: needinfo?(bhearsum)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: