Closed Bug 1804973 Opened 1 year ago Closed 1 year ago

Crash in [@ wl_egl_window_get_attached_size]


(Core :: Widget: Gtk, defect, P3)




110 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox107 --- unaffected
firefox108 --- unaffected
firefox109 --- fixed
firefox110 --- fixed


(Reporter: mccr8, Assigned: stransky)


(Blocks 1 open bug, Regression)


(Keywords: crash, regression)

Crash Data


(1 file)

Crash report:


Top 10 frames of crashing thread:

0  wl_egl_window_get_attached_size  /usr/src/debug/wayland/wayland-1.21.0/egl/wayland-egl.c:115
1  moz_container_wayland_egl_window_needs_size_update  widget/gtk/MozContainerWayland.cpp:711
2  nsWindow::SetEGLNativeWindowSize  widget/gtk/nsWindow.cpp:9681
3  mozilla::wr::RenderCompositorEGL::BeginFrame  gfx/webrender_bindings/RenderCompositorEGL.cpp:93
4  mozilla::wr::RendererOGL::UpdateAndRender  gfx/webrender_bindings/RendererOGL.cpp:164
4  mozilla::wr::RenderThread::UpdateAndRender  gfx/webrender_bindings/RenderThread.cpp:581
5  mozilla::wr::RenderThread::HandleFrameOneDocInner  gfx/webrender_bindings/RenderThread.cpp:440
6  mozilla::wr::RenderThread::HandleFrameOneDoc  gfx/webrender_bindings/RenderThread.cpp:392
7  mozilla::detail::RunnableMethodArguments<mozilla::wr::WrWindowId, bool, bool>::applyImpl<mozilla::wr::RenderThread, void   xpcom/threads/nsThreadUtils.h:1162
7  mozilla::detail::RunnableMethodArguments<mozilla::wr::WrWindowId, bool, bool>::apply<mozilla::wr::RenderThread, void   xpcom/threads/nsThreadUtils.h:1168

The crash comment is "Firefox Wayland session on KDE. Uncheck "Title bar" in customization."

bug 1795851 added wl_egl_window_get_attached_size.

Blocks: wayland
Keywords: regression
OS: Unspecified → Linux
Regressed by: 1795851

:stransky, since you are the author of the regressor, bug 1795851, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Flags: needinfo?(stransky)

Set release status flags based on info from the regressing bug 1795851

Assignee: nobody → stransky
Flags: needinfo?(stransky)
Priority: -- → P3
Pushed by
[Wayland] Check size for valid EGLWindows only r=emilio
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
Duplicate of this bug: 1810297

It seems this needs to be backported to 109, see bug 1810297 comment 9.

Flags: needinfo?(stransky)

Looks like we missed time to backport it.

Flags: needinfo?(stransky)

Let's get this into the next 109 dot release. Please nominate when you get a chance, Martin.

Flags: needinfo?(stransky)
Crash Signature: [@ wl_egl_window_get_attached_size] → [@ wl_egl_window_get_attached_size] [@ ]

There are crashes with [@] as signature for Firefox 109.0. 13 crashes for 9 installations e.g. bp-87933918-346f-4e56-9758-4ead80230117 The crashes are without symbols so far.

Comment on attachment 9308224 [details]
Bug 1804973 [Wayland] Check size for valid EGLWindows only r?emilio

Beta/Release Uplift Approval Request

  • User impact if declined: Crashes on Wayland when Firefox window is resized before it's fully created (i.e. crash after start when window is resized early).
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Don't update EGL window size when it's not created yet. What can go wrong here?
  • String changes made/needed:
  • Is Android affected?: No
Flags: needinfo?(stransky)
Attachment #9308224 - Flags: approval-mozilla-release?

I wonder which build is that. Does Ubuntu 22.04.1 run Firefox on Wayland by default?

No, we're still running release builds under XWayland by default on Ubuntu. I was surprised to see Ubuntu crashes in there too, but I guess people can always manually force it to run with Wayland enabled still even if that isn't the shipping configuration. Hopefully that at least limits the severity of this in the wild (especially if Fedora's patching their v109 builds too).

Yes, Fedora ships downstream patch for it.

Comment on attachment 9308224 [details]
Bug 1804973 [Wayland] Check size for valid EGLWindows only r?emilio

Approved for 109.0.1.

Attachment #9308224 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.