1805135 - FileSystemWritableFileStream should use the default writer for all IO operations

Status: RESOLVED FIXED

(Core :: DOM: File, task, P2)

Description

[Jan Varga [:janv]]

FileSystemWritableFileStream::Write, FileSystemWritableFileStream::Seek and FileSystemWritableFileStream::Truncate currently bypass the default writer mechanism provided by the parent class/interface WritableFileStream. This can lead to ordering issues.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1805135 - Fix FileSystemWritableFileStream to use the default writer for all IO operations; r=#dom-storage

Depends on D157823

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e5d5b851391
Fix FileSystemWritableFileStream to use the default writer for all IO operations; r=dom-storage-reviewers,webidl,smaug,jari

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for Hazard bustages on FileSystemWritableFileStream.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/75e27831b02fc8f0cf306fd61717df9d534455d1
Log link: https://treeherder.mozilla.org/logviewer?job_id=399461644&repo=autoland&lineNumber=84656

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aec85fd6e08a
Fix FileSystemWritableFileStream to use the default writer for all IO operations; r=dom-storage-reviewers,webidl,smaug,jari

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/aec85fd6e08a

Comment 6

[Jan Varga [:janv]]

Landed after fixing a rooting hazard.