1805184 - Glean isn't disabled immediately when telemetry pref is toggled

Status: RESOLVED FIXED

(Focus :: General, defect)

Description

[Travis Long [:travis_]]

Currently, only Legacy telemetry is disabled immediately when the "Send Usage Data" preference is toggled. Glean is only passed the value of the preference into its initialize function, but should also have its setUploadEnabled called when the preference is toggled:

https://github.com/mozilla-mobile/focus-android/blob/bfef7c20e0a902feeaeac33895c00ad5424eb8d7/app/src/main/java/org/mozilla/focus/widget/TelemetrySwitchPreference.kt#L29

Steps to reproduce

1. Disable telemetry via the preference

Expected behavior

Glean upload is immediately disabled and a deletion-request ping submitted

Actual behavior

Glean isn't disabled until the next application launch, meaning we could collect telemetry and send it even after the preference is disabled (at least until the app is restarted).

Device information

• Focus version: Current version
• Android device model: N/A
• Android OS version: N/A

Any additional information?

While we do perform the correct actions on the next application launch, this isn't quite fitting with Mozilla data policy and should be addressed.

Comment 1

[Chris H-C :chutten]

Attachment: GitHub Pull Request

Comment 2

[Travis Long [:travis_]]

This has been merged, closing as FIXED

Comment 3

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1805184 - Enable or disable Glean collection and upload immediately. (#392)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ede60a45125e
[focus] Bug 1805184 - Enable or disable Glean collection and upload immediately.