1805269 - Disable Navigator requestGamepadServiceTest and requestVRServiceTest outside of testing environments

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Andrew McCreight [:mccr8]]

These two bits of device testing mockups are already guarded behind a pref, but as a bit of a hardening measure we could also check xpc::IsInAutomation. The other VR testing interfaces can only be created once you have the test interface, so I think it will protect those, too.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1805269 - Don't allow getting gamepad and VR test services outside of automation.

These interfaces are already disabled by prefs, but they are ironically
probably not well tested, so just add an extra check.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d94fded02d5
Don't allow getting gamepad and VR test services outside of automation. r=smaug,cmartin

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5d94fded02d5

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 9307899 [details]
Bug 1805269 - Don't allow getting gamepad and VR test services outside of automation.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is a hardening measure that will protect some unmaintained VR code against being accidentally exposed to users if they flip a pref.
• User impact if declined: see above
• Fix Landed on Version: 109
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only affects the behavior when a non-standard pref is flipped. It may break some manual testing of VR or gamepad APIs.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9307899 [details]
Bug 1805269 - Don't allow getting gamepad and VR test services outside of automation.

Approved for 109.0b5 and 102.7esr.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/906c5b4774c2

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4cf2fc8ae704