1805445 - Generalize priority support in the IPDL compiler

Status: RESOLVED FIXED

(Core :: IPC, task, P3)

Description

[Andrew McCreight [:mccr8]]

We have a ton of priorities in IPDL now. It might be worth generalizing things instead of having little bits of boilerplate scattered around. I'm imagining an array of pairs, where the first part of the pair is the IPDL name and the second part is the C++ name. The internal enum value would be an index into the array.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

There was some discussion on Matrix and it was pointed out that priority is currently a 3-bit field, so this will need a little subtlety if we want to add more than 3 new priorities (+ the current 5).

Comment 2

[Andrew McCreight [:mccr8]]

I was mostly thinking about the representation of priority values in the IPDL compiler itself, but that's good to keep in mind.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1805445 - Centralize defining a new priority in the IPDL compiler.

This patch makes it so that you only need to add a new element to a list
to add a new priority to the IPDL compiler.

Comment 4

[Andrew McCreight [:mccr8]]

A similar thing could be done for the nested attributes, but hopefully nobody is clamoring to add lots more of those.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fda8e2847c51
Centralize defining a new priority in the IPDL compiler. r=nika

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fda8e2847c51