1805447 - Implement RTCDtlsTransport.onerror

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, task, P3)

Description

[Byron Campen [:bwc]]

Marking P2 since we're the only holdout.

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1805447: Implement RTCError for DTLS. r?jib,nkulatova

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1805447: Test-cases for RTCDtlsTransport.onerror. r?jib,nkulatova

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d9abecf0db52
https://hg.mozilla.org/integration/autoland/rev/5385cba898fd
Test-cases for RTCDtlsTransport.onerror. r=jib,nkulatova
https://github.com/mozilla-firefox/firefox/commit/753d5b225c1f
https://hg.mozilla.org/integration/autoland/rev/c0456642af51
Implement RTCError for DTLS. r=jib,nkulatova,webidl,smaug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0ef1421b4e9f
https://hg.mozilla.org/integration/autoland/rev/fd848dd0ea1c
Revert "Bug 1805447: Implement RTCError for DTLS. r=jib,nkulatova,webidl,smaug" for causing build bustages on PMediaTransport.

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing build bustages on PMediaTransport.

Push with failures

Failure log

Backout link

Comment 7

[Byron Campen [:bwc]]

Hmm, interesting, iOS isn't picking up the same types as everywhere else...

Comment 8

[Byron Campen [:bwc]]

Ah, this looks like a MOZ_WEBRTC=0 situation.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/227e26be356f
https://hg.mozilla.org/integration/autoland/rev/9bd59de26e2f
Test-cases for RTCDtlsTransport.onerror. r=jib,nkulatova
https://github.com/mozilla-firefox/firefox/commit/59e735e1e2a4
https://hg.mozilla.org/integration/autoland/rev/d21dd606bfc2
Implement RTCError for DTLS. r=jib,nkulatova,webidl,smaug

Comment 10

[Byron Campen [:bwc]]

Harumph. Another build failure, this time a unified build failure on Linux snap. A job that cannot be scheduled even with ./mach try fuzzy --full.

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/61210 for changes under testing/web-platform/tests

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9bd59de26e2f
https://hg.mozilla.org/mozilla-central/rev/d21dd606bfc2

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 15

[Hamish Willee]

FF154 MDN docs work for this can be tracked via https://github.com/mdn/content/issues/44835

Comment 16

[Philipp Hancke [:fippo]]

Attachment: Bug 1805447: suppress dtls error on ice failures

Comment 17

[BugBot [:suhaib / :marco]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 18

[Phabricator Automation]

Comment on attachment 9640083 [details]
Bug 1805447: suppress dtls error on ice failures

Revision D324735 was moved to bug 2071008. Setting attachment 9640083 [details] to obsolete.

Comment 19

[Phabricator Automation]

Comment on attachment 9640083 [details]
Bug 1805447: suppress dtls error on ice failures

Revision D324735 was moved to bug 2071008. Setting attachment 9640083 [details] to obsolete.