1805479 - Add "initiator" to "network.beforeRequestSent" event

Status: NEW

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

BiDi network events should contain Initiator data defined in the current PR as

network.Initiator = {
    type: "parser" / "script" / "preflight" / "other",
    ?columnNumber: uint,
    ?lineNumber: uint,
    ?stackTrace: StackTrace,
    ?request: network.Request
};

At the time of filing the logic to compute the type is not clear:

TODO: Get the type. It’s not quite clear how this ought to work; the CDP data depends on whether the navigation was kicked off by the parser or by script (so e.g. inserting an image from script causes the initiator to be "script"), but that doesn’t correspond to anything in Fetch.

Also stackTrace information is not accessible from the parent process, so it will be more complicated to add this information, since for ow our implementation for beforeRequestSent lives only in the parent process.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

After talking to Julian we are going to de-prioritize this bug for now. We will re-evaluate once it becomes a blocker for some WebDriver BiDi API.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's used in some P2 Puppeteer tests and users wanted to have it for CDP so most likely BiDi as well. We should check how hard it is to implement.

Comment 4

[Julian Descottes [:jdescottes]]

We will split out the stacktrace part out if this bug, but this still requires clarification to know which initiator type should be set for which use cases.

Comment 5

[Julian Descottes [:jdescottes]]

For reference, the current logic to handle this in DevTools can be found around https://searchfox.org/mozilla-central/rev/3c72de9280ec57dc55c24886c6334d9e340500e8/devtools/shared/network-observer/NetworkUtils.sys.mjs#24-69

Of course we might need to change it to make it spec compliant.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Julian, as it looks like this is only needed for the network.beforeRequestSent event or do I miss something?

Comment 7

[Julian Descottes [:jdescottes]]

That's correct, updated the bug accordingly