1805529 - The Sqlite.sys.mjs module may open connections too late on shutdown

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect, P3)

Description

[Marco Bonardo [:mak]]

There's 2 problems:

1. There may be a delay between AsyncShutdown setting _done = true in the PromiseSet and Sqlite.sys.mjs setting isClosed.
2. We may check isClosed it's still false, then we invoke openAsyncDatabase (or asyncClone) that us asynchronous, by the time the callback returns the handle, isClosed is now true. The consumer will receive the connection and may try to add a shutdown blocker to close it, but it's too late. It's better to close the connection if by the time we get it it's too late.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1805529 - The Sqlite.sys.mjs module may open connections too late on shutdown. r=gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d1f87d5eb0e
The Sqlite.sys.mjs module may open connections too late on shutdown. r=Gijs

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4d1f87d5eb0e