1805589 - Pocket newtab topsites add Discovery Stream topsites to topsite list earlier

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Scott [:thecount] Downe]

This should fix a handful of bugs and edge cases.

Similar solution to bug 1804511 but less involved change.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1805589 - Pocket newtab add Discovery Stream topsites to topsites list earlier.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51080108cc0d
Pocket newtab add Discovery Stream topsites to topsites list earlier. r=nanj

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser/components/newtab/test/browser/abouthomecache/browser_no_startup_actions.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/abouthomecache/browser_no_startup_actions.js | Should be no non-startup actions. - 1 == 0 - {"filename":"chrome://mochitests/content/browser/browser/components/newtab/test/browser/abouthomecache/browser_no_startup_actions.js","name":"test_no_startup_actions/<","sourceId":633,"lineNumber":67,"columnNumber":12,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formatte

Comment 4

[Mike Conley (:mconley) (:⚙️)]

This failed because a TOP_SITES_UPDATED was observed firing, and that action doesn't have the isStartup meta property.

Comment 5

[Scott [:thecount] Downe]

Thanks, that's it. I think I got it, pushing up a fix.

You saved me a lot of debugging time :D

Comment 6

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/a4e2776e8718

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08d5509f937d
Pocket newtab add Discovery Stream topsites to topsites list earlier.

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/08d5509f937d