1805614 - [wpt-sync] Sync PR 37496 - [ComputePressure] Resolve the issue when calling observe method multiple times without using await

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 37496 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37496
Details from upstream follow.

Wei4 Wang <[e-mail]> wrote:

[ComputePressure] Resolve the issue when calling observe method multiple times without using await

In current implementation, when we call observe method on the same
observer like this:
let promise1 = observer.observe('cpu');
let promise2 = observer.observe('cpu');
or when we call observe method on different observers like this:
let promise1 = observer1.observe('cpu');
let promise2 = observer2.observe('cpu');
promise2 is resolved before promise1 no matter promise1 is resolved
or rejected. This CL resolves this issue by returning the same Promise
for same observer case or making status of promise2 depend on promise1
for different observers case.

Bug: 1393210, 1360396
Change-Id: I580953c6ff586bd517eae610d695c4e55ff80ded
Reviewed-on: https://chromium-review.googlesource.com/4104850
WPT-Export-Revision: b3cd0e365f7343efed30c0942cf694e28bd9ca22

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6e6f4f21b7aa78d47f5c9e73a96c9a11d565f02

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 2 subtests

Status Summary

Firefox

OK : 4
FAIL : 10

Chrome

OK : 1
CRASH: 3
FAIL : 5

Safari

OK : 4
FAIL : 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /compute-pressure/compute_pressure_basic_async.tentative.https.window.html [wpt.fyi]
  • Return NotSupportedError when calling observer(): FAIL (Chrome: FAIL, Safari: FAIL)
  • Basic functionality test: FAIL (Chrome: FAIL, Safari: FAIL)
  • Removing observer before observe() resolves works: FAIL (Chrome: FAIL, Safari: FAIL)
  • Calling observe() multiple times works: FAIL (Chrome: FAIL, Safari: FAIL)
  • Starting a new observer after an observer has started works: FAIL (Chrome: FAIL, Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect.tentative.https.window.html [wpt.fyi]
  • Call disconnect() directly should not crash: FAIL (Safari: FAIL)
  • Stopped PressureObserver do not receive changes: FAIL (Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect_idempotent.tentative.https.window.html [wpt.fyi]
  • Stopped PressureObserver do not receive changes: FAIL (Safari: FAIL)
• /compute-pressure/compute_pressure_disconnect_immediately.tentative.https.window.html [wpt.fyi]
  • Stopped PressureObserver do not receive changes: FAIL (Safari: FAIL)
  • Removing observer before observe() resolves does not affect other observers: FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/659ed5a3fdd1
[wpt PR 37496] - [ComputePressure] Resolve/reject the promises correctly when calling observe method., a=testonly
https://hg.mozilla.org/integration/autoland/rev/38decae1b864
[wpt PR 37496] - Update wpt metadata, a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/659ed5a3fdd1
https://hg.mozilla.org/mozilla-central/rev/38decae1b864