1805622 - Remove JSContext from Parser

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

In the same way as bug 1804837 and bug 1805141.
JSContext* const cx_; field should be removed from Parser.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1805622 - Part 1: Remove unused forward declarations and includes. r?bthrall!

Depends on D166145

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1805622 - Part 2: Do not use JSContext* in StringBuffer in Parser. r?bthrall!

Depends on D166147

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1805622 - Part 3: Add FrontendContext variant of DuplicateString and use it in ScriptSource. r?bthrall!

Depends on D166148

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1805622 - Part 4: Use maybeCurrentJSContext in ScriptSource::setDisplayURL. r?bthrall!

Depends on D166149

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1805622 - Part 5: Remove JSContext* parameter from ScriptSource::set* methods. r?bthrall!

Depends on D166150

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1805622 - Part 6: Use FrontendContext::hadErrors in Parser. r?bthrall!

Depends on D166151

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1805622 - Part 7: Use FrontendAllocator::new_ in Parser. r?bthrall!

Depends on D166152

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1805622 - Part 8: Remove unused JSContext* parameter. r?bthrall!

Depends on D166153

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1805622 - Part 9: Remove JSContext* parameter from CompileAsmJS. r?bthrall!

Depends on D166154

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1805622 - Part 10: Use CompilationState.parserAllocScope for RegExp parsing. r?bthrall!

Depends on D166155

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1805622 - Part 11: Use maybeCurrentJSContext in liftParserAtomToJSAtom. r?bthrall!

Depends on D166156

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1805622 - Part 12: Remove ParserBase::cx_. r?bthrall!

Depends on D166157

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:arai, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2dbf6868ea1
Part 1: Remove unused forward declarations and includes. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/20e7d4cf1629
Part 2: Do not use JSContext* in StringBuffer in Parser. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/87cc7d44ce7e
Part 3: Add FrontendContext variant of DuplicateString and use it in ScriptSource. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/c0d221ee5d0c
Part 4: Use maybeCurrentJSContext in ScriptSource::setDisplayURL. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/832bfa520a9d
Part 5: Remove JSContext* parameter from ScriptSource::set* methods. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/2b1b9d123eec
Part 6: Use FrontendContext::hadErrors in Parser. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/4496b81f4e33
Part 7: Use FrontendAllocator::new_ in Parser. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/43bb19928205
Part 8: Remove unused JSContext* parameter. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/8c11839bc010
Part 9: Remove JSContext* parameter from CompileAsmJS. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/4ae107d0e4bf
Part 10: Use CompilationState.parserAllocScope for RegExp parsing. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/c4b89f4346e1
Part 11: Use maybeCurrentJSContext in liftParserAtomToJSAtom. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/76e857bc64b7
Part 12: Remove ParserBase::cx_. r=bthrall

Comment 15

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f2dbf6868ea1
https://hg.mozilla.org/mozilla-central/rev/20e7d4cf1629
https://hg.mozilla.org/mozilla-central/rev/87cc7d44ce7e
https://hg.mozilla.org/mozilla-central/rev/c0d221ee5d0c
https://hg.mozilla.org/mozilla-central/rev/832bfa520a9d
https://hg.mozilla.org/mozilla-central/rev/2b1b9d123eec
https://hg.mozilla.org/mozilla-central/rev/4496b81f4e33
https://hg.mozilla.org/mozilla-central/rev/43bb19928205
https://hg.mozilla.org/mozilla-central/rev/8c11839bc010
https://hg.mozilla.org/mozilla-central/rev/4ae107d0e4bf
https://hg.mozilla.org/mozilla-central/rev/c4b89f4346e1
https://hg.mozilla.org/mozilla-central/rev/76e857bc64b7