Closed Bug 1805645 Opened 2 years ago Closed 2 years ago

Add irregexp::CheckPatternSyntax with LifoAlloc instead of JSContext

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

irregexp::CheckPatternSyntax used by frontend receives JSContext to get LifoAlloc.

https://searchfox.org/mozilla-central/rev/43cb6eca1c3069d46d589d52ab4949257e630d19/js/src/irregexp/RegExpAPI.cpp#287,293

static bool CheckPatternSyntaxImpl(JSContext* cx,
...
  LifoAllocScope allocScope(&cx->tempLifoAlloc());

Directly receiving LifoAlloc allows removing JSContext from Parser.

Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/0c0a7b6b9f4b Use LifoAlloc instead of JSContext as parameter type of irregexp::CheckPatternSyntax. r=iain
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: