Closed Bug 1805693 Opened 10 months ago Closed 7 months ago

[meta] Improve the usability and logic of the Edit Recurrence dialog

Categories

(Calendar :: Dialogs, enhancement)

enhancement

Tracking

(thunderbird_esr102 wontfix)

RESOLVED FIXED
111 Branch
Tracking Status
thunderbird_esr102 --- wontfix

People

(Reporter: aleca, Assigned: elizabeth)

References

(Blocks 1 open bug)

Details

(Keywords: meta, Whiteboard: [fixed by bug 1805938, and maybe others])

Attachments

(2 files)

The Edit Recurrence dialog comes with a pretty silly UX aimed at offering users the ability to see the highlighted dates based on the their recurrence preferences.

What's wrong

  • The minimonth used in this dialog doesn't get the new style.
  • This dialog adds extra months whenever it's resized and then it stores the new size int he XUL store.
  • After extra months are added is impossible to make dialog smaller.
  • The tests covering this area need to do some sketchy await in order to pass in mochitest.

What to do

Keywords: meta
Summary: Improve the usability and logic of the Edit Recurrence dialog → [meta] Improve the usability and logic of the Edit Recurrence dialog
Depends on: 1805763
Depends on: 1805767
Status: NEW → ASSIGNED

The code in that dialog is indeed a bit nonsense. I had actually reworked it in https://phabricator.services.mozilla.com/D139279 but haven't landed that yet since it has test failures on windows which I didn't yet get back to. If you want to steal it, feel more than welcome.

That the number of months change depending on size... I think we could keep it. When it was broken we did get a bug report that someone was depending on it, and for longer recurrences it does make some sense wrt planning.

The code in that dialog is indeed a bit nonsense. I had actually reworked it in https://phabricator.services.mozilla.com/D139279 but haven't landed that yet since it has test failures on windows which I didn't yet get back to. If you want to steal it, feel more than welcome.

Ah nice, good to know.
We won't touch the dialog structure in this bug but simply tackle the minmonth implementation inside of it, so this body of work is a bit unrelated.

That the number of months change depending on size... I think we could keep it

I'm sorry but absolutely not.
That's the weirdest piece of UX I've ever seen and just because someone finds it useful it doesn't mean it's right.
Showing 3 months, and being able to switch months and navigate through the year is enough to allow users to see how their recurrence visually translates on the calendar.

Depends on: 1805938
Attached image image.png

Drive-by comment: Note that the bold day numbers only appear for the first month.

This is currently working in my active patch for bug 1805938. I'm hoping to get a patch ready for review in the next few days.

Depends on: 1812435
See Also: → 1679129
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 1805938, and maybe others]
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.