180574 - ban, unban aliases not implemented

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Wilhelm Svenselius]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021115
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021115

the CIRCChanUser object (in irc.js) has setOp, setVoice, kick, kickBan and
setBan methods defined, but there are only corresponding commands for setOp (/op
/deop), setVoice (/voice, /devoice), and kick (/kick). Where are the commands
(or aliases in mIRCspeak) for kickban and ban/unban? They ought to be in
commands.js and handlers.js, but they're not.

I wrote my own version of /kickban by coping onInputKick and replacing "kick"
with "kickBan" in the appropriate places. It works fine, but I'm puzzled as to
why this rather basic functionality hasn't made it in yet.

Reproducible: Always

Steps to Reproduce:
1. Connect to a server, join a channel, attain op status.
2. Try to kickban using the /kickban command.
3. Try to set or unset a ban using the /ban or /unban commands.

Actual Results:  
An error message was displayed.

Expected Results:  
Called the appropriate method in CIRCChanUser, causing the appropriate action
(kickban/ban/unban) to be taken.

Comment 1

[Frank Wein [:mcsmurf]]

Confirming

As far as I see, there has to be implanted that at line
http://lxr.mozilla.org/mozilla/source/extensions/irc/js/lib/irc.js#1312 (or
elsewhere but there you can see how its done)

Comment 2

[Frank Wein [:mcsmurf]]

Ok, i checked: In the popular irc-client mirc there is only /ban implanted. Ok,
we could also implant your commands in chatzilla, no question :)

Comment 3

[James Ross]

The 0.9.46 version I'm using right now has got a /kick-ban command, so that's
been done. That leaves just ban/unban, updating summary.

Comment 4

[James Ross]

Attachment: Add /ban and /unban

This adds ban and unban, both of which attempt to find the nickname on the
current channel or current server, and if that fails bans either "nickname!*@*"
or if the input has ! or @ in it, the exact input.

Comment 5

[Mike Shaver (:shaver emeritus)]

Comment on attachment 180984 [details] [diff] [review]
Add /ban and /unban

a=shaver.

Comment 6

[James Ross]

Checked in -> FIXED.