1805799 - Crash in `TSFTextStore::Selection::Length` if logging IMEHandler:4

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away until 10/14)]

Attachment: Bug 1805799 - Make `TSFTextStore::Selection::Length` use `MOZ_ASSERT_IF` instead of `MOZ_ASSERT` to access `Maybe<TS_SELECTION_ACP>` r=m_kato!

ToString(mSelectionForTSF).c_str() runs TSFTextStore::Selection::operator<<
if it's some. Then, it calls TSFTextStore::Selection::Length always.
https://searchfox.org/mozilla-central/rev/17aeb39742eba71e0936ae44a51a54197100166d/widget/windows/TSFTextStore.h#725

However, TSFTextStore::Selection::mACP can be nothing if there is no
Selection ranges. Therefore, the MOZ_ASSERT(mACP->acpEnd >= mACP->acpStart)
hits Maybe<T>.isSome() check in -> operator.
https://searchfox.org/mozilla-central/rev/17aeb39742eba71e0936ae44a51a54197100166d/widget/windows/TSFTextStore.h#681

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/badee7c29983
Make `TSFTextStore::Selection::Length` use `MOZ_ASSERT_IF` instead of `MOZ_ASSERT` to access `Maybe<TS_SELECTION_ACP>` r=m_kato

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/badee7c29983