[mlk] remove nsIControllers.commandDispatcher to break cycle

VERIFIED FIXED in M11

Status

()

Core
XUL
P3
critical
VERIFIED FIXED
18 years ago
9 years ago

People

(Reporter: Chris Waterson, Assigned: Chris Waterson)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
There is an unnecessary cycle that starts and ends at a XUL element:

1. The element's `mControllers' slot holds an nsXULControllers object.
2. The nsXULControllers object holds an nsXULCommandDispatcher object.
3. The nsXULCommandDispatcher object holds an nsXULElement.

It turns out that (according to hyatt), the reference from nsXULControllers to
nsXULCommandDispatcher is old and crufty and superceded by nsXULDocument's
ownership of the command dispatcher. I've verified this by grovelling through
the existing JS and XUL that refers to a 'commandDispatcher' attribute.

Breaking this dependency fixes a -monster- leak.
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
Target Milestone: M11
(Assignee)

Comment 1

18 years ago
marking M11. fixing this leak will make XUL 99.9% clean
(Assignee)

Comment 2

18 years ago
Created attachment 2652 [details] [diff] [review]
proposed fix
(Assignee)

Updated

18 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

18 years ago
fix checked in, r=hyatt a=chofmann

Updated

18 years ago
Status: RESOLVED → VERIFIED

Comment 4

18 years ago
marking verified

Comment 5

18 years ago
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL

Updated

9 years ago
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: ckritzer → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.