1805808 - Contribute button for addons should open in the external browser, not a TB tab

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[b7]

+++ This bug was initially created as a clone of Bug #1795751 +++

It's nice that this got fixed, but the link should open in an external browser. People might not feel comfortable to conduct a PayPal transaction in TB (although it appears to be working unlike the links on the release notes page (bug 1794180)).

Same reasoning as here:
https://searchfox.org/comm-central/rev/4d3e74705f69e67938bd2b2520171f435385472f/mail/base/content/msgMail3PaneWindow.js#803

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1805808 - Open UI links externally. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4a32005db538
Open UI links externally. r=mkmelin

Comment 3

[John Bieling (:TbSync)]

Comment on attachment 9308514 [details]
Bug 1805808 - Open UI links externally. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Add-on donation page opens in Thunderbird instead of an external browser.

Testing completed (on c-c, etc.):
Just landed on Daily.

Risk to taking this patch (and alternatives if risky):
Very low. The function is used only for this single purpose in TB. I would like to get this on ESR as fast as possible.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9308514 [details]
Bug 1805808 - Open UI links externally. r=mkmelin

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 109.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/a1fdcfaf66eb

Comment 6

[John Bieling (:TbSync)]

Comment on attachment 9308514 [details]
Bug 1805808 - Open UI links externally. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined:
Add-on donation page opens in Thunderbird instead of an external browser.

Testing completed (on c-c, etc.):
1 month on Beta

Risk to taking this patch (and alternatives if risky):
Very low. The function is used only for this single purpose in TB.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9308514 [details]
Bug 1805808 - Open UI links externally. r=mkmelin

[Triage Comment]
approved for esr102

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 102.7.1:
https://hg.mozilla.org/releases/comm-esr102/rev/5fb99921701a