Closed Bug 1805839 Opened 1 year ago Closed 1 year ago

Do not auto-format *.mako.* files

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

defect

Tracking

(firefox110 fixed)

RESOLVED FIXED
Tracking Status
firefox110 --- fixed

People

(Reporter: sergesanspaille, Assigned: sergesanspaille)

References

Details

Attachments

(1 file)

Files using the mako templating system are suffixed by the host language extension, e.g. name.mako.py or name.mako.rs. This confuses the auto-formatter which wants to format them while being unaware of the templating syntax. Blacklist these files for rust and black formatters (the two only extensions in tree matching *.mako.*)

Note: those files should probably have the $ext.mako extension instead of mako.$ext

The template syntax is incompatible with the host language syntax.

Blocks: 1800952

The severity field is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(bpostelnicu)

Are you waiting for something before landing the patch?

Flags: needinfo?(sguelton)

I don't have landing super power :-)

Flags: needinfo?(sguelton)
Pushed by oriol-bugzilla@hotmail.com:
https://hg.mozilla.org/integration/autoland/rev/c76443d7cf19
Do not auto-format mako.XY template files r=sheehan,linter-reviewers,sylvestre
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Flags: needinfo?(bpostelnicu)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: