1805928 - Enable dismissing from all screens in multistage Spotlight messages

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Meg Viar [:mviar]]

Currently, there is no special message action that allows a user to close a multistage Spotlight message. Previous uses of the dismiss button component have relied on setting the action with "navigate: true". This only closes the modal if the user is on the last screen of a multistage message or if the message only has one screen.

To support this behavior we might add a new special message action. A "CANCEL" action already exists, but the behavior is slightly different than what we want here and only works for CFRs.

Comment 1

[Meg Viar [:mviar]]

Attachment: Bug 1805928 - Add dimiss action to about welcome to allow dismissing from all multistage Spotlight modal screens

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6928cc53a68d
Add dimiss action to about welcome to allow dismissing from all multistage Spotlight modal screens r=omc-reviewers,emcminn

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6928cc53a68d

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 111.0a1 (Build ID: 20230130214413) on Windows 10 x64, macOS 11.7.1, and Ubuntu 22.04 x64.

• After following the steps from this Test Plan, I can confirm the following:
  • A “DISMISS” ping is displayed on the Browser Console after dismissing the “MULTISTAGE_SPOTLIGHT_MESSAGE” message by pressing the “Esc” key, clicking the “X” button or clicking on the primary button (Its action is set to { "dismiss": true }).
  • This event is registered whether the message is set as a window or tab modal.