1806025 - New wpt failures in /css/css-images/image-set/ [image-set-type-unsupported-rendering-2.html, image-set-type-unsupported-rendering.html]

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P3)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Syncing wpt PR 37497 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

• /css/css-images/image-set/image-set-type-unsupported-rendering-2.html [wpt.fyi]: FAIL
• /css/css-images/image-set/image-set-type-unsupported-rendering.html [wpt.fyi]: FAIL

CI Results

Missing results from treeherder
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1805624 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

This test is wrong, the spec explicitly states:

This has no effect on the validity of the image-set() function

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1806025 - Fix image-set type() tests. r=#style,#layout-reviewers

The test is wrong. The spec is very clear that the image-set() function
shouldn't become invalid due to the type() argument.

The spec doesn't explicitly define what happens when none of the items
are valid, so for now use our behavior (just first image), but
https://github.com/w3c/csswg-drafts/issues/8266 is on file to possibly
change this behavior.

In any case the tests before this patch should never render green.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cc8cc1231f4
Fix image-set type() tests. r=dholbert

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38364 for changes under testing/web-platform/tests

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6cc8cc1231f4

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot