1806049 - Tidy up some FastDivisor things

Status: RESOLVED FIXED

(Core :: Memory Allocator, task, P2)

Description

[Paul Bone [:pbone]]

This is a follow-up for Bug 1743322 that tidies up a few things that could be improved.

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1806049 - Improve some code comments r=glandium

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1806049 - Rename the FastDivisor variables r=glandium

Rename the m and p variables to match those used in the Hacker's Delight
book where the algorithm is presented. There were also some inconsistent
names in comments that this fixes.

Depends on D164886

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1806049 - Test all divisions r=glandium

Don't wait until runtime to test that all valid divisions work. Test them
during initialisation in debug builds.

Depends on D164887

Comment 4

[Paul Bone [:pbone]]

Attachment: Bug 1806049 - Explicitly use uint32_t r=glandium

We want to be precise about types used here. Although in practice unsigned
is the same as uint32_t, it's not guaranteed. We want to definitely use
32-bit multiplication as it can be faster than 64-bit.

Depends on D164888

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18d20db4c000
Improve some code comments r=glandium
https://hg.mozilla.org/integration/autoland/rev/f969998c988e
Rename the FastDivisor variables r=glandium
https://hg.mozilla.org/integration/autoland/rev/3b565e52fea8
Test all divisions r=glandium
https://hg.mozilla.org/integration/autoland/rev/16b643d610fc
Explicitly use uint32_t r=glandium

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/18d20db4c000
https://hg.mozilla.org/mozilla-central/rev/f969998c988e
https://hg.mozilla.org/mozilla-central/rev/3b565e52fea8
https://hg.mozilla.org/mozilla-central/rev/16b643d610fc