1806066 - The second onboarding screen isn't dismissed after setting the default browser

Status: RESOLVED FIXED

(Focus :: General, defect, P2)

Description

[Mira Lobontiu (Android QA)]

Attachment: onboarding.mp4

Steps to reproduce

1. Install Focus Beta 109.0b1, or Focus Nightly 109.0a1 build.
2. On the first onboarding screen, tap the "Get started" option.
3. On the second onboarding screen, tap the "Set as default browser" option.
4. Set Focus the default browser.
5. Tap the back arrow, in order to be sent back to the Focus app.

Expected behavior

The second onboarding screen is dismissed, the homescreen is displayed, the keyboard triggered.

Actual behavior

The second onboarding screen is not yet dismissed. The user can tap again on the "Set as default browser" option - the screen is now dismissed.

Device information

• Focus version: all (RC 108.1.0, Beta 109.0b1, Nightly 109.0a1)
• Devices affected: Sony Xperia Z5 Premium (Android 7.1.1), Samsung Galaxy Note 8 (Android 9)
• Not reproducible on Lenovo tab M10 (Android 10)

Any additional information?

If the user doesn't select Focus Nightly as the default browser, tapping on the "Set a default browser" redirects the user back to settings to set the "correct" default browser.

Comment 1

[Mira Lobontiu (Android QA)]

Attachment: logcat Beta.txt

Comment 2

[Chris Peterson [:cpeterson]]

Romain, is this onboarding screen shown to all new Focus users? What is the expected behavior?

Comment 3

[Mira Lobontiu (Android QA)]

The new onboarding is now available too all new Focus users.
The expected behavior is: after the user selects Focus app as default, tapping back to be returned to Focus app, dismisses automatically the onboarding screen.

Comment 4

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1806066 - Finish onboarding when Focus is set as default browser. (#568)

Comment 5

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Focus nightly 111.0a1 from 1/25, with the following devices:

• Sony Xperia Z5 Premium (Android 7.1.1),
• Samsung Galaxy Note 8 (Android 9), and
• HTC 10 (Android 8).

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this something we should nominate for v110 backport?

Comment 7

[Mihai Adrian Carare [:mcarare]]

The severity is S3 and only some devices are likely to be affected. Also, it does not prevent setting as the default browser, it just does offer visual feedback properly to the action of setting it. So, I would say it's not something critical.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd2f39c4841d
Remove redirection to SUMO page for Huawei devices.
https://hg.mozilla.org/integration/autoland/rev/415556a573e5
Finish onboarding on Focus set as default browser from OS settings.
https://hg.mozilla.org/integration/autoland/rev/816c202926d8
Set proper tag for ActivityNotFoundException.