Closed Bug 1806176 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 37562 - Added default resolution support in css image-set

Categories

(Core :: Layout: Images, Video, and HTML Frames, task, P4)

Product:
Core
Component:
Layout: Images, Video, and HTML Frames
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
110 Branch
Tracking Flags:
Tracking Status
firefox110 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37562 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37562
Details from upstream follow.

Traian Captan <tcaptan@chromium.org> wrote:

Added default resolution support in css image-set

Currently, if the resolution of an image-set value is missing, parsing
fails.

Based on the spec, the resolution is optional and should default to 1x
if not specified.

Spec definition:
"A \<resolution> (optional). This is used to help the UA decide which
\<image-set-option> to choose. If the image reference is for a raster
image, it also specifies the image’s natural resolution, overriding any
other source of data that might supply a natural resolution.

If not specified, it behaves as 1x for the purpose of selecting which
\<image-set-option> to use. It also defaults the image’s natural
resolution to 1x, but if some other source of data supplies a natural
resolution, that resolution must be honored instead."

https://w3c.github.io/csswg-drafts/css-images-4/#image-set-notation

R=masonf, pdr

Fixed: 1400898
Change-Id: I6d15966d88307cfdfa6ce00e9fca3a64fcfceea5
Reviewed-on: https://chromium-review.googlesource.com/4112418
WPT-Export-Revision: 3550e83c3fc66ce2699a778bddd33e3ee55814e5

Component: web-platform-tests → Layout: Images, Video, and HTML Frames
Product: Testing → Core

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

OK : 1
PASS: 56[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 57[GitHub]
FAIL: 4[Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, GitHub] 5[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt]

Chrome

OK : 1
PASS: 22
FAIL: 39

Safari

OK : 1
PASS: 37
FAIL: 24

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-images/image-set/image-set-parsing.html [wpt.fyi]
    • e.style['content'] = "image-set(linear-gradient(black, white) 1x, 'example.png' 4x)" should set the property value: FAIL (Chrome: FAIL, Safari: PASS)
    • e.style['content'] = "-webkit-image-set(linear-gradient(black, white) 1x, 'example.png' 4x)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['content'] = "image-set(url("example.png") 192dpi, linear-gradient(black, white) 1x)" should set the property value: FAIL (Chrome: FAIL, Safari: PASS)
    • e.style['content'] = "-webkit-image-set(url("example.png") 192dpi, linear-gradient(black, white) 1x)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-images/image-set/image-set-no-res-rendering-2.html [wpt.fyi]: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], PASS [GitHub] (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a2d36e5101f7 [wpt PR 37562] - Added default resolution support in css image-set, a=testonly https://hg.mozilla.org/integration/autoland/rev/578fadd23e5b [wpt PR 37562] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a2d36e5101f7
https://hg.mozilla.org/mozilla-central/rev/578fadd23e5b

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox110: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.