apply_declarations shouldn't just pass None as the originating_element_style
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: Oriol, Assigned: Oriol)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
In bug 1805898 I forgot to pass the style of the originating element when apply_declarations is used for a pseudo-element.
This prevents container units from working properly.
WebKit seems to have a similar problem.
|
Assignee | |
Comment 1•1 year ago
|
||
They fail in Gecko and WebKit.
|
|
Assignee | |
Comment 2•1 year ago
|
||
When apply_declarations is used for a pseudo-element, make it pass the
parent_style as the originating_element_style for container queries.
This requires changing some parameters from Option<&Arc<ComputedValues>>
to Option<&ComputedValues>.
It's not a complete solution, since e.g. parent_style is not the style
of the originating element of a ::backdrop. But here it's not as simple
as in D164908, so leaving these details for later.
Depends on D164976
|
||
Comment 3•1 year ago
|
||
This makes me a bit happier about the previous patch :)
Pushed by oriol-bugzilla@hotmail.com: https://hg.mozilla.org/integration/autoland/rev/1cda45f38086 Add tests for container units in pseudo-elements. r=emilio https://hg.mozilla.org/integration/autoland/rev/bcf35b173bde Partial fix for container units in pseudo-elements. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37615 for changes under testing/web-platform/tests
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1cda45f38086
https://hg.mozilla.org/mozilla-central/rev/bcf35b173bde
Upstream PR merged by moz-wptsync-bot
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b99441011750 Avoid generic soup and extra reference count bumps. r=dshin
|
||
Comment 9•1 year ago
•
|
||
Backed out for causing bustages.
Backout link: https://hg.mozilla.org/integration/autoland/rev/e74732c628125cc5179b2d9d5de039a8eb6ade4a
Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=dQr06JNpQa-rmiSGxKx5hQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=3f63f21115e28d9cc2244984941105eb31d21a99
Failure log: https://treeherder.mozilla.org/logviewer?job_id=400842961&repo=autoland&lineNumber=45561
|
||
Comment 10•1 year ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/84cc269a53c1 Avoid generic soup and extra reference count bumps. r=dshin
|
||
Comment 11•1 year ago
|
||
| bugherder | ||
|
|
||
Updated•1 year ago
|
Description
•