1806362 - FS: Add infrastructure for verifying SyncAccessHandle quota management

Status: RESOLVED FIXED

(Core :: DOM: File, task, P2)

Description

[Jan Varga [:janv]]

An xpcshell test for verifying SyncAccessHandle quota management revealed some small bugs which need to be addressed.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1806362 - Recreate FileSystemManagerChild after it was destroyed; r=#dom-storage

The actor is destroyed during origin clearing or resetting.

Depends on D159880

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1806362 - FileQuotaStreamWithWrite::Write should return zero written bytes in the failure case; r=#dom-storage

This bug causes NS_AsyncCopy to call the progress callback with random values
when there's an error during writing.

Depends on D165069

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1806362 - Enable nsIQuotaManagerService methods for testing; r=#dom-storage

Some tests will need to use nsIQuotaManagerService::Reset.

Depends on D165070

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1806362 - Introduce Utils in tests with a method for shrinking storage size; r=#dom-storage

The new method is needed for testing quota management and it works in xpcshell
tests including workers in xpcshell tests.

Depends on D165071

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1806362 - Add a test to verify SyncAccessHandle quota management; r=#dom-storage

Depends on D165072

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ad750172e57
Recreate FileSystemManagerChild after it was destroyed; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/0bdd4eb728e3
FileQuotaStreamWithWrite::Write should return zero written bytes in the failure case; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/b21e0aaab0db
Enable nsIQuotaManagerService methods for testing; r=dom-storage-reviewers,jari

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing Gtest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/46735d6081efdae1c8d1f2f6dee2d49bd176596b

Push with failures

Failure log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/180a8d7b3429
Recreate FileSystemManagerChild after it was destroyed; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/31627dd1ef99
FileQuotaStreamWithWrite::Write should return zero written bytes in the failure case; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/fbc422a876ba
Enable nsIQuotaManagerService methods for testing; r=dom-storage-reviewers,jari

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/180a8d7b3429
https://hg.mozilla.org/mozilla-central/rev/31627dd1ef99
https://hg.mozilla.org/mozilla-central/rev/fbc422a876ba

Comment 10

[Phabricator Automation]

Comment on attachment 9309024 [details]
Bug 1806362 - Introduce Utils in tests with a method for shrinking storage size; r=#dom-storage

Revision D165072 was moved to bug 1815696. Setting attachment 9309024 [details] to obsolete.

Comment 11

[Phabricator Automation]

Comment on attachment 9309025 [details]
Bug 1806362 - Add a test to verify SyncAccessHandle quota management; r=#dom-storage

Revision D165073 was moved to bug 1815696. Setting attachment 9309025 [details] to obsolete.