1806391 - [macOS 10.12-10.14] Crash in [@ VP3CreateInstance]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

94 crashes from ~80 installations of Firefox v108 builds (both 108.0 and 108.0.1 affected) on macOS 10.12-10.14

Is this a regression from bug 1792257?

Crash report: https://crash-stats.mozilla.org/report/index/69867983-5236-481e-be7d-8ee6b0221219

Reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS

Top 10 frames of crashing thread:

0  AppleVA  VP3CreateInstance  
1  VideoToolbox  VCH263VideoDecoder_CreateInstance  
2  VideoToolbox  VTDecompressionSessionCreateWithOptions  
3  VideoToolbox  VTDecompressionSessionCreate  
4  XUL  mozilla::AppleVTDecoder::InitializeSession  dom/media/platforms/apple/AppleVTDecoder.cpp:551
5  XUL  mozilla::AppleDecoderModule::CanCreateHWDecoder  dom/media/platforms/apple/AppleDecoderModule.cpp:202
6  XUL  mozilla::AppleDecoderModule::Supports const  dom/media/platforms/apple/AppleDecoderModule.cpp:120
7  XUL  mozilla::PDMFactory::GetDecoderModule const  dom/media/platforms/PDMFactory.cpp:773
7  XUL  mozilla::PDMFactory::Supports const  dom/media/platforms/PDMFactory.cpp:478
8  XUL  mozilla::MP4Decoder::IsSupportedType  dom/media/mp4/MP4Decoder.cpp:193

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Kind of surprising to me that this is showing up as a parent process crash.

Comment 2

[az [:az]]

Will put together a patch for this, thanks!

Comment 3

[az [:az]]

Attachment: Bug 1806391 - Remove OS X PDM H264 hardware acceleration check to prevent crashes in 10.12-10.14 r=jolin

Comment 4

[az [:az]]

Have a patch up on Phab but don't currently have access to a 10.12-10.14 machine to verify, could somebody from QA or with a machine with that OS please take a look? (I used the regressionwindow-wanted keyword -- please let me know if there's a better keyword I should use.) Will check back in tomorrow morning to confirm from my side + with jolin before landing.

Comment 5

[Jim Mathies [:jimm]]

Good for a ride-along to release if it's an easy fix.

Comment 6

[az [:az]]

Adding a link to a try build.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 5 desktop browser crashes on Mac on release

For more information, please visit auto_nag documentation.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30eebaf414ab
Remove OS X PDM H264 hardware acceleration check to prevent crashes in 10.12-10.14 r=jolin

Comment 9

[az [:az]]

Haven't been able to repro. Landed patch in nightly which reverts the H264 logic and should clear this up, will monitor.

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/30eebaf414ab

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Go ahead and nominate this for Beta approval when you get a chance.

Comment 12

[az [:az]]

Comment on attachment 9309082 [details]
Bug 1806391 - Remove OS X PDM H264 hardware acceleration check to prevent crashes in 10.12-10.14 r=jolin

Beta/Release Uplift Approval Request

• User impact if declined: Possible crashes in H264 video playback on OS X 10.12-10.14
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Haven't been able to reproduce. Appears to be caused when during H264 playback on OSX 10.12-10.14. Crash report protected information contains a link to a video streaming site that I've verified streams H264 video.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Change should not be risky as it is reverting logic to previous
• String changes made/needed:
• Is Android affected?: No

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9309082 [details]
Bug 1806391 - Remove OS X PDM H264 hardware acceleration check to prevent crashes in 10.12-10.14 r=jolin

Approved for 109.0b7.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/95206f670369

Comment 15

[Mihai Boldan, Desktop QA [:mboldan]]

We tried to reproduce the issue without any luck, so we cannot confirm the fix.
Tests were performed under macOS 10.12, macOS 10.13 and under macOS 10.14.
Also we tried to reproduce the issue on Firefox 108, Firefox 108.0.1 and on Firefox 109.0b6, using .pkg and .dmg installation files and also covered 'en-US' and 'de' localizations.
For testing we used all the links from the crash report and also a few random h.264 videos.
If we can help further with the investigation, please add again the qe+ flag.

Comment 16

[Dianna Smith [:diannaS]]

can you nominate this for release for the 108.0.2 dot release?

Comment 17

[az [:az]]

Comment on attachment 9309082 [details]
Bug 1806391 - Remove OS X PDM H264 hardware acceleration check to prevent crashes in 10.12-10.14 r=jolin

Beta/Release Uplift Approval Request

• User impact if declined: Possible crashes in H264 video playback on OS X 10.12-10.14
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Crashes have stopped in nightly. This bug does have two regressions tied to it which appear to be minor.
• String changes made/needed:
• Is Android affected?: No

Comment 18

[Dianna Smith [:diannaS]]

Comment on attachment 9309082 [details]
Bug 1806391 - Remove OS X PDM H264 hardware acceleration check to prevent crashes in 10.12-10.14 r=jolin

Approved for 108.0.2

Comment 19

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/1cbe38b757aa