1806444 - firefox-android: Do not run tasks for mergify branches on git-push

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Johan Lorenzo [:jlorenzo]]

In mozilla-mobile/fenix#17489 and
mozilla-mobile/android-components#9421, :bhearsum made sure we don't run mergify when it backports a PR.

Last week, we migrated the focus-android repository into the new Android monorepo and I realized we keep running these tasks[1]. I even stumbled upon this weird Chain of Trust error[2]:

2022-12-16T12:19:51 CRITICAL - scriptworker:build:docker-image:parent aeJ7kr4OR5W7Gf64jtQS3w: the runtime task doesn't match any rebuilt definition!
[]
2022-12-16T12:19:51 CRITICAL - Chain of Trust verification error!
Traceback (most recent call last):
  File "/app/lib/python3.9/site-packages/scriptworker/cot/verify.py", line 1707, in verify_parent_task
    await verify_parent_task_definition(chain, link)
  File "/app/lib/python3.9/site-packages/scriptworker/cot/verify.py", line 1581, in verify_parent_task_definition
    compare_jsone_task_definition(parent_link, rebuilt_definitions)
  File "/app/lib/python3.9/site-packages/scriptworker/cot/verify.py", line 1664, in compare_jsone_task_definition
    raise CoTError(error_msg)
scriptworker.exceptions.CoTError: "scriptworker:build:docker-image:parent aeJ7kr4OR5W7Gf64jtQS3w: the runtime task doesn't match any rebuilt definition!\n[]"
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/app/lib/python3.9/site-packages/scriptworker/cot/verify.py", line 2025, in verify_chain_of_trust
    await verify_task_types(chain)
  File "/app/lib/python3.9/site-packages/scriptworker/cot/verify.py", line 1783, in verify_task_types
    await valid_task_types[task_type](chain, obj)
  File "/app/lib/python3.9/site-packages/scriptworker/cot/verify.py", line 1709, in verify_parent_task
    raise CoTError(e)

After looking into it, it seems this condition[3] head_ref[:8] != "mergify/" isn't met. head_ref starts with refs/heads/my_branch_name. That explains why CoT says the rebuilt definition is an empty task. CoT doesn't prepend refs/heads/.

I don't know when we regressed this.

[1] https://github.com/mozilla-mobile/firefox-android/pull/366
[2] https://firefox-ci-tc.services.mozilla.com/tasks/C0t0--01TpqoGCk_p6isRA/runs/0/logs/public/logs/chain_of_trust.log
[3] https://github.com/mozilla-mobile/firefox-android/blob/6e4a27a29c4d901fe6d34199b3725c2cde4077c3/.taskcluster.yml#L133

Comment 1

[BMO Automation]

Attachment: [mozilla-releng/staging-firefox-android] [DO NOT MERGE] Bug 1806444 before: Add dummy file to create a PR (#19)

Comment 2

[BMO Automation]

Attachment: [mozilla-releng/staging-firefox-android] [DO NOT MERGE] Bug 1806444 before: Add dummy file to create a PR (backport #19) (#20)

Comment 3

[BMO Automation]

Attachment: [mozilla-releng/staging-firefox-android] [DO NOT MERGE] Bug 1806444 after: Add dummy file to create a PR (#21)

Comment 4

[BMO Automation]

Attachment: [mozilla-releng/staging-firefox-android] [DO NOT MERGE] Bug 1806444 after: Add dummy file to create a PR (backport #21) (#22)

Comment 5

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1806444 - Do not run tasks for mergify branches on git-push (#400)

Comment 6

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1806444 - Do not run tasks for mergify branches on git-push (backport #400) (#401)

Comment 7

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1806444 - Do not run tasks for mergify branches on git-push (backport #400) (#402)

Comment 8

[Johan Lorenzo [:jlorenzo]]

All pieces have landed and I confirm the most recent backports don't schedule jobs twice!

[1] e.g. https://github.com/mozilla-mobile/firefox-android/pull/406

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c48acb8968b0
part 1: Reorder `$let` and `$if` statements without changing them
https://hg.mozilla.org/integration/autoland/rev/acd121ade335
part 2: Use `short_head_ref` to know if we are dealing with mergify branches