1806451 - Superfluous inwindowmenu=false attributes

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[:Gijs (he/him)]

See https://searchfox.org/mozilla-central/search?q=inwindowmenu - these stopped doing anything after the change in bug 1642138 - I guess they should have been removed at the time?

Comment 1

[Stephen A Pohl [:spohl]]

(In reply to :Gijs (he/him) from comment #0)

See https://searchfox.org/mozilla-central/search?q=inwindowmenu - these stopped doing anything after the change in bug 1642138 - I guess they should have been removed at the time?

Thanks for the heads up. It looks like we've lost the functionality mentioned here: https://searchfox.org/mozilla-central/source/browser/base/content/webrtcIndicator.js#108-110, however there doesn't seem to be a way to do this without losing the functionality implemented in bug 1642138...

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1642138

Comment 3

[Stephen A Pohl [:spohl]]

(In reply to Stephen A Pohl [:spohl] from comment #1)

(In reply to :Gijs (he/him) from comment #0)

See https://searchfox.org/mozilla-central/search?q=inwindowmenu - these stopped doing anything after the change in bug 1642138 - I guess they should have been removed at the time?

Thanks for the heads up. It looks like we've lost the functionality mentioned here: https://searchfox.org/mozilla-central/source/browser/base/content/webrtcIndicator.js#108-110, however there doesn't seem to be a way to do this without losing the functionality implemented in bug 1642138...

Actually, it looks like this could be possible by not setting a window title. But I'm not entirely sure how to test this indicator, and whether dynamically changing the window title has the desired result. Would you know how to test this?

Comment 4

[:Gijs (he/him)]

(In reply to Stephen A Pohl [:spohl] from comment #3)

(In reply to Stephen A Pohl [:spohl] from comment #1)

(In reply to :Gijs (he/him) from comment #0)

See https://searchfox.org/mozilla-central/search?q=inwindowmenu - these stopped doing anything after the change in bug 1642138 - I guess they should have been removed at the time?

Thanks for the heads up. It looks like we've lost the functionality mentioned here: https://searchfox.org/mozilla-central/source/browser/base/content/webrtcIndicator.js#108-110, however there doesn't seem to be a way to do this without losing the functionality implemented in bug 1642138...

Actually, it looks like this could be possible by not setting a window title.

Do we perhaps already do this for the about dialog? That also has this attribute (source link) and I still don't see it in the window menu.

But I'm not entirely sure how to test this indicator, and whether dynamically changing the window title has the desired result. Would you know how to test this?

It shows up when using webrtc - per https://bugzilla.mozilla.org/show_bug.cgi?id=1665490#c0 perhaps only when sharing a screen via webrtc? :mconley might have more solid STR.

Comment 5

[Stephen A Pohl [:spohl]]

I just spoke with :mconley on Matrix. I'm working on a possible fix. And yes, the about dialog works correctly by not setting a window title. Need to test if we can do this dynamically for the WebRTC global indicator.

Comment 6

[Stephen A Pohl [:spohl]]

Attachment: Bug 1806451: Remove superfluous and non-functional inwindowmenu attributes. r=Gijs

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42b0ce8616da
Remove superfluous and non-functional inwindowmenu attributes. r=Gijs

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/42b0ce8616da

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Is this something we'd want to backport to 109?

Comment 10

[Stephen A Pohl [:spohl]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)

Is this something we'd want to backport to 109?

No. This bug does not have any user-visible effects. However, I'm working on the related bug 1800550 and we may want to backport that if I can get a fix for it soon.