1806500 - Replace Cu.reportError calls in dom and uriloader

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Mark Banner (:standard8)]

We are working towards removing Cu.reportError in preference to the more standard console.error. This bug is for the dom and urloader.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1806500 - Automatically replace Cu.reportError with console.error (uriloader dom). r?smaug!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/146a11389a42
Automatically replace Cu.reportError with console.error (uriloader dom). r=smaug

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in dom/console/tests/test_bug659625.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/24cbbaefe74dce0fbfcf230985b73e66a32bd27e

Push with failures

Failure log

INFO -  Buffered messages finished
[task 2022-12-20T08:10:31.392Z] 08:10:31  WARNING -  TEST-UNEXPECTED-FAIL | dom/console/tests/test_bug659625.html | 1 new console event registered for trace
[task 2022-12-20T08:10:31.392Z] 08:10:31     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:404:16
[task 2022-12-20T08:10:31.392Z] 08:10:31     INFO -      @dom/console/tests/test_bug659625.html:42:5
[task 2022-12-20T08:10:31.392Z] 08:10:31  WARNING -  TEST-UNEXPECTED-FAIL | dom/console/tests/test_bug659625.html | Only one event remains in consoleAPIStorage
[task 2022-12-20T08:10:31.392Z] 08:10:31     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:404:16
[task 2022-12-20T08:10:31.392Z] 08:10:31     INFO -      clearAndCheckStorage@dom/console/tests/test_bug659625.html:21:7
[task 2022-12-20T08:10:31.393Z] 08:10:31     INFO -      @dom/console/tests/test_bug659625.html:44:3
[task 2022-12-20T08:10:31.393Z] 08:10:31  WARNING -  TEST-UNEXPECTED-FAIL | dom/console/tests/test_bug659625.html | Remaining event has level 'clear'
[task 2022-12-20T08:10:31.393Z] 08:10:31     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:404:16
[task 2022-12-20T08:10:31.393Z] 08:10:31     INFO -      clearAndCheckStorage@dom/console/tests/test_bug659625.html:23:7
[task 2022-12-20T08:10:31.393Z] 08:10:31     INFO -      @dom/console/tests/test_bug659625.html:44:3
[task 2022-12-20T08:10:31.393Z] 08:10:31  WARNING -  TEST-UNEXPECTED-FAIL | dom/console/tests/test_bug659625.html | 1 new console event registered for dir
[task 2022-12-20T08:10:31.393Z] 08:10:31     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:404:16
[task 2022-12-20T08:10:31.393Z] 08:10:31     INFO -      @dom/console/tests/test_bug659625.html:47:5
[task 2022-12-20T08:10:31.393Z] 08:10:31  WARNING -  TEST-UNEXPECTED-FAIL | dom/console/tests/test_bug659625.html | Only one event remains in consoleAPIStorage

Comment 4

[Mark Banner (:standard8)]

Oh, I missed running the mochitest-plain tests on try :( Will fix.

Comment 5

[Mark Banner (:standard8)]

Ok, there's an issue with the GeckoViewConsole.jsm on Android that wasn't caught previously as this test wasn't listening for Cu.reportError output. I will undo the changes to dom/console and land those in a separate follow-up.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4be804d1c686
Automatically replace Cu.reportError with console.error (uriloader dom). r=smaug

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ace02ead001
Backed out changeset 4be804d1c686 for causing mochitest failures on test_has_permissions.html. CLOSED TREE

Comment 8

[Marian-Vasile Laza]

Backed out changeset 4be804d1c686 (Bug 1806500) for causing mochitest failures on test_has_permissions.html.
Backout link
Push with failures <--> 1
Failure Log

Comment 9

[Mark Banner (:standard8)]

Oh, this failed earlier, but unfortunately I didn't receive notification about it. Will investigate.

Comment 10

[BugBot [:suhaib / :marco]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:standard8, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 11

[Mark Banner (:standard8)]

I've undone the change for mockpushserviceparent.js which will get test_has_permissions.html passing again. I'll work out a fix for that in a follow-up.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60da248cccaa
Automatically replace Cu.reportError with console.error (uriloader dom). r=smaug

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/60da248cccaa