1806518 - WebRTC preview video is cut off in the popupnotification when asked what screen/window to share

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Itiel]

Attachment: Screenshot

See attached.
The inline-end (left) side of the preview video is cut off.

STR is to open https://www.webrtc-experiment.com/Pluginfree-Screen-Sharing, click "Share Your Screen" and select one of the screens in the dropdown.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1806518 - Simplify webrtc video preview styles. r=Itiel,dao

We only need to allow the video to shrink horizontally in case the video
is wider than the panel max width, the rest works out just fine.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fd7ff625ea0
Simplify webrtc video preview styles. r=Itiel

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1790616

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7fd7ff625ea0

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9309057 [details]
Bug 1806518 - Simplify webrtc video preview styles. r=Itiel,dao

Beta/Release Uplift Approval Request

• User impact if declined: well scoped CSS fix.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very well scoped.
• String changes made/needed: none
• Is Android affected?: No

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9309057 [details]
Bug 1806518 - Simplify webrtc video preview styles. r=Itiel,dao

Approved for 109.0b6.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/47882cf01993

Comment 9

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible with Firefox 108.0.1(he-locale) on Windows 10.
Verified as fixed on Firefoox 109.0b6(build ID: 20221222190305, he-locale) and Nightly 110.0a1(build ID: 20221223043251, he-locale) on Windows 10, Windows 11, macOS 12, Ubuntu 22.