1806519 - Give BrowserGlue startup idle tasks a name

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[Florian Quèze [:florian]]

BrowserGlue has 2 ways to schedule startup idle tasks. Since bug 1613390, we add profiler markers when running the tasks, but the tasks don't have name, making the markers less useful than they could be.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1806519 - Give BrowserGlue startup idle tasks a name, r=dthayer.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Task Configuration' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Julien Cristau [:jcristau]]

bugbug is wrong.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ee3e9831e8a
Give BrowserGlue startup idle tasks a name, r=dthayer.

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on BrowserGlue.sys.mjs

• backout: https://hg.mozilla.org/integration/autoland/rev/46d61edff678adfd577c4ab6dfb86e98d3c4c1fd
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=8ee3e9831e8ac49684b4f253729e271a1ee81ebc
• failure log: https://treeherder.mozilla.org/logviewer?job_id=400608359&repo=autoland&lineNumber=2536

[task 2022-12-23T10:36:32.509Z] 10:36:32     INFO - Buffered messages finished
[task 2022-12-23T10:36:32.512Z] 10:36:32     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_openImportCSV.js | [JavaScript Error: "can't access property "_gmpInstallManager", this is undefined" {file: "resource:///modules/BrowserGlue.sys.mjs" line: 2928}]
[task 2022-12-23T10:36:32.512Z] 10:36:32     INFO - GMPInstallManagerSimpleCheckAndInstall@resource:///modules/BrowserGlue.sys.mjs:2928:35
[task 2022-12-23T10:36:32.513Z] 10:36:32     INFO - _scheduleBestEffortUserIdleTasks/<@resource:///modules/BrowserGlue.sys.mjs:2990:19
[task 2022-12-23T10:36:32.514Z] 10:36:32     INFO -  - false == true - JS frame :: chrome://mochitests/content/browser/browser/components/aboutlogins/tests/browser/head.js :: onConsoleMessage :: line 161
[task 2022-12-23T10:36:32.514Z] 10:36:32     INFO - Stack trace:
[task 2022-12-23T10:36:32.514Z] 10:36:32     INFO - chrome://mochitests/content/browser/browser/components/aboutlogins/tests/browser/head.js:onConsoleMessage:161
[task 2022-12-23T10:36:32.514Z] 10:36:32     INFO - resource://specialpowers/SpecialPowersChild.sys.mjs:observe/<:114
[task 2022-12-23T10:36:32.515Z] 10:36:32     INFO - Console message: [JavaScript Error: "can't access property "_addBreachesSyncHandler", this is undefined" {file: "resource:///modules/BrowserGlue.sys.mjs" line: 2936}]
[task 2022-12-23T10:36:32.515Z] 10:36:32     INFO - RemoteSettingsInit@resource:///modules/BrowserGlue.sys.mjs:2936:9
[task 2022-12-23T10:36:32.516Z] 10:36:32     INFO - _scheduleBestEffortUserIdleTasks/<@resource:///modules/BrowserGlue.sys.mjs:2990:19
[task 2022-12-23T10:36:32.516Z] 10:36:32     INFO - 

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b245260c335
Give BrowserGlue startup idle tasks a name, r=dthayer.

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7b245260c335