Extend the eslint pre-commit hook to also lint mjs files and other files we lint
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Tracking
(firefox110 fixed)
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: florian, Assigned: standard8)
Details
Attachments
(1 file)
When running hg ci, I was surprised that changes I made in a .sys.mjs file were not reformatted.
I think this is because https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/tools/lint/hooks_js_format.py#36 doesn't contain the extension for new ES6 modules.
|
Assignee | |
Comment 1•1 year ago
|
||
We should make this any .mjs file (since we have those as well), as well as the other types of files that we currently support.
|
|
Assignee | |
Comment 2•1 year ago
|
||
Although, I'm not sure how many people use this hook these days - we don't seem to advertise it anywhere.
|
|
Assignee | |
Comment 3•1 year ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e252a63796f8 Extend the eslint pre-commit hook to also lint mjs files and other files we lint. r=linter-reviewers,sylvestre
|
Reporter | |
Comment 5•1 year ago
|
||
(In reply to Mark Banner (:standard8) from comment #2)
Although, I'm not sure how many people use this hook these days - we don't seem to advertise it anywhere.
It's possible I didn't point the the right file in the code. The hook I'm interested in is the one that gets automatically added to the mercurial configuration by mach bootstrap. But maybe that one has already been fixed and I just needed to run mach bootstrap again.
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
Description
•