1806522 - Extend the eslint pre-commit hook to also lint mjs files and other files we lint

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Florian Quèze [:florian]]

When running hg ci, I was surprised that changes I made in a .sys.mjs file were not reformatted.

I think this is because https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/tools/lint/hooks_js_format.py#36 doesn't contain the extension for new ES6 modules.

Comment 1

[Mark Banner (:standard8)]

We should make this any .mjs file (since we have those as well), as well as the other types of files that we currently support.

Comment 2

[Mark Banner (:standard8)]

Although, I'm not sure how many people use this hook these days - we don't seem to advertise it anywhere.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1806522 - Extend the eslint pre-commit hook to also lint mjs files and other files we lint. r?#linter-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e252a63796f8
Extend the eslint pre-commit hook to also lint mjs files and other files we lint. r=linter-reviewers,sylvestre

Comment 5

[Florian Quèze [:florian]]

(In reply to Mark Banner (:standard8) from comment #2)

Although, I'm not sure how many people use this hook these days - we don't seem to advertise it anywhere.

It's possible I didn't point the the right file in the code. The hook I'm interested in is the one that gets automatically added to the mercurial configuration by mach bootstrap. But maybe that one has already been fixed and I just needed to run mach bootstrap again.

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e252a63796f8