Open Bug 1806571 Opened 2 years ago Updated 2 years ago

New wpt failures in /svg/painting/parsing/ [stroke-dashoffset-valid.svg, stroke-width-valid.svg]

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wpt])

Syncing wpt PR 37588 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

  • /svg/painting/parsing/stroke-dashoffset-valid.svg [wpt.fyi]
    • e.style['stroke-dashoffset'] = "calc(3)" should set the property value: FAIL
    • e.style['stroke-dashoffset'] = "calc(2 + 1)" should set the property value: FAIL
    • e.style['stroke-dashoffset'] = "calc(2 + (7 - 5))" should set the property value: FAIL
  • /svg/painting/parsing/stroke-width-valid.svg [wpt.fyi]
    • e.style['stroke-width'] = "calc(3)" should set the property value: FAIL
    • e.style['stroke-width'] = "calc(2 + 1)" should set the property value: FAIL
    • e.style['stroke-width'] = "calc(2 + (7 - 5))" should set the property value: FAIL

New Tests That Don't Pass

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1806538 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

The failures seem to be associated with setting these properties (as CSS properties, not as attributes) to unitless <number> values.

As of SVG1.1, e.g. stroke-width only accepted <percentage> | <length> (with units) -- not <number>:
https://www.w3.org/TR/SVG11/painting.html#StrokeWidthProperty

And the published version of SVG2 , stroke-width still accepts only <length-percentage>:
https://www.w3.org/TR/SVG2/painting.html#StrokeWidth

Name: 	stroke-width
Value: 	<length-percentage>

But indeed, in the draft, <number> has been added as well:
https://svgwg.org/svg2-draft/painting.html#StrokeWidth

Name: 	stroke-width
Value: 	<length-percentage> | <number>

So this must've been a recent change.

Severity: -- → S3

Er, "recent" is relative I suppose; looks like the last published version of SVG2 is from 2018.

This <number> was added to the draft a bit later in 2018, in https://github.com/w3c/svgwg/commit/461bf611f79268ae143f303f724abeb5edf2f9b5#diff-0472d21fc9d9c050788cb4ca0200a29d0915fe03feda3149babc69139ac2d512R728 for https://github.com/w3c/svgwg/issues/534

See Also: → https://github.com/w3c/svgwg/issues/534
Blocks: svg2
You need to log in before you can comment on or make changes to this bug.