Closed
Bug 1806632
Opened 3 months ago
Closed 3 months ago
Remove unused gridlines class from EdAdvancedEdit
Categories
(SeaMonkey :: Composer, task)
SeaMonkey
Composer
Tracking
(seamonkey2.53+ affected)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.16)
Attachments
(2 files)
3.69 KB,
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
3.69 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
frg
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Since the fix to Bug 1430742 was landed the class gridlines is now unused (and according that bug did nothing anyway), so should be removed.
Attachment #9309146 -
Flags: review?(frgrahl)
[Approval Request Comment]
Regression caused by (bug #): 1430742
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.16
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9309148 -
Flags: review?(frgrahl)
Attachment #9309148 -
Flags: approval-comm-release?
Attachment #9309148 -
Flags: approval-comm-esr60?
![]() |
||
Comment 3•3 months ago
|
||
Comment on attachment 9309146 [details] [diff] [review]
1806632-cc.patch
LGTM
Attachment #9309146 -
Flags: review?(frgrahl) → review+
![]() |
||
Updated•3 months ago
|
![]() |
||
Comment 4•3 months ago
|
||
Comment on attachment 9309148 [details] [diff] [review]
1800632-gridlines-sm-25316.patch
LGTM
Attachment #9309148 -
Flags: review?(frgrahl)
Attachment #9309148 -
Flags: review+
Attachment #9309148 -
Flags: approval-comm-release?
Attachment #9309148 -
Flags: approval-comm-release+
Attachment #9309148 -
Flags: approval-comm-esr60?
Attachment #9309148 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/8668746d0405
Remove unused gridlines class from EdAdvancedEdit. r=frg
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•