Closed Bug 1806632 Opened 3 months ago Closed 3 months ago

Remove unused gridlines class from EdAdvancedEdit

Categories

(SeaMonkey :: Composer, task)

Product:
SeaMonkey
Component:
Composer
Type:
task

Tracking

(seamonkey2.53+ affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
seamonkey2.53 + affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.16)

Attachments

(2 files)

1806632-cc.patch
3.69 KB, patch
frg
: review+
Details | Diff | Splinter Review
1800632-gridlines-sm-25316.patch
3.69 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

Since the fix to Bug 1430742 was landed the class gridlines is now unused (and according that bug did nothing anyway), so should be removed.

Attached patch 1806632-cc.patch — — Splinter Review
Attachment #9309146 - Flags: review?(frgrahl)

[Approval Request Comment]
Regression caused by (bug #): 1430742
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.16
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9309148 - Flags: review?(frgrahl)
Attachment #9309148 - Flags: approval-comm-release?
Attachment #9309148 - Flags: approval-comm-esr60?

Comment on attachment 9309146 [details] [diff] [review]
1806632-cc.patch

LGTM

Attachment #9309146 - Flags: review?(frgrahl) → review+
status-seamonkey2.53: --- → affected
tracking-seamonkey2.53: --- → +
Whiteboard: SM2.53.16

Comment on attachment 9309148 [details] [diff] [review]
1800632-gridlines-sm-25316.patch

LGTM

Attachment #9309148 - Flags: review?(frgrahl)
Attachment #9309148 - Flags: review+
Attachment #9309148 - Flags: approval-comm-release?
Attachment #9309148 - Flags: approval-comm-release+
Attachment #9309148 - Flags: approval-comm-esr60?
Attachment #9309148 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/8668746d0405
Remove unused gridlines class from EdAdvancedEdit. r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.