Closed Bug 1806632 Opened 11 months ago Closed 11 months ago

Remove unused gridlines class from EdAdvancedEdit

Categories

(SeaMonkey :: Composer, task)

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.16)

Attachments

(2 files)

Since the fix to Bug 1430742 was landed the class gridlines is now unused (and according that bug did nothing anyway), so should be removed.

Attached patch 1806632-cc.patchSplinter Review
Attachment #9309146 - Flags: review?(frgrahl)

[Approval Request Comment]
Regression caused by (bug #): 1430742
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.16
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9309148 - Flags: review?(frgrahl)
Attachment #9309148 - Flags: approval-comm-release?
Attachment #9309148 - Flags: approval-comm-esr60?

Comment on attachment 9309146 [details] [diff] [review]
1806632-cc.patch

LGTM

Attachment #9309146 - Flags: review?(frgrahl) → review+
Whiteboard: SM2.53.16

Comment on attachment 9309148 [details] [diff] [review]
1800632-gridlines-sm-25316.patch

LGTM

Attachment #9309148 - Flags: review?(frgrahl)
Attachment #9309148 - Flags: review+
Attachment #9309148 - Flags: approval-comm-release?
Attachment #9309148 - Flags: approval-comm-release+
Attachment #9309148 - Flags: approval-comm-esr60?
Attachment #9309148 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/8668746d0405
Remove unused gridlines class from EdAdvancedEdit. r=frg

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.