1806723 - Replace Cu.reportError calls in dom/console/ConsoleAPIStorage.jsm

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Mark Banner (:standard8)]

I originally tried doing this in bug 1806500, but dom/console/tests/test_bug659625.html failed on android.

Tracking it down, I found that GeckoViewConsole.jsm is not properly handling console messages with no arguments, e.g. console.trace(). As a result, it throws, which ConsoleAPIStorage catches.

With the new version, it logs it to the console (rather than via Cu.reportError), which the test picks up as an unexpected message, and hence the test fails.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1806723 - Fix GeckoViewConsole to handle console calls with no arguments. r?#geckoview-reviewers!

This handles a call to console.trace() with no arguments, which is what happens in dom/console/tests/test_bug659625.html.
The failure is currently hidden from the test because it only checks the console log, not the output of Cu.reportError.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1806723 - Replace Cu.reportError with console.error in dom/console code. r?smaug!

Depends on D165203

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8b626abdc06
Fix GeckoViewConsole to handle console calls with no arguments. r=geckoview-reviewers,calu
https://hg.mozilla.org/integration/autoland/rev/0fe58dc368a7
Replace Cu.reportError with console.error in dom/console code. r=smaug

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a8b626abdc06
https://hg.mozilla.org/mozilla-central/rev/0fe58dc368a7