180674 - Missing queryCharset in google.src

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Walter Wlodarski]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021102 Phoenix/0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2b) Gecko/20021102 Phoenix/0.4

The Google search, in the Mozilla-search toolbar, doesn't provide the right
character set info to conduct proper searches in other characters set than
Western ISO 8859-1.

For exemple, a query in japanese doesn't work.

Reproducible: Always

Steps to Reproduce:
1. type japanese characters in the Google search toolbar (テスト)
Actual Results:  
Query interpreted by Google as if it was ???

Expected Results:  
Google results for テスト

A possible solution:

Adding queryCharset="UTF-8" in searchplugins/google.src

<search
name="Google"
description="Google Search"
method="GET"
action="http://www.google.com/search"
update="http://www.google.com/mozilla/google.src"
updateCheckDays=1
queryCharset="UTF-8"
>

Comment 1

[Sébastien Delahaye]

-> asa
(ref: http://www.mozillazine.org/forums/viewtopic.php?t=789 )

Comment 2

[Simon Paquet [:sipaq]]

Attachment: Patch with the changes proposed by Walter

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 107912 [details] [diff] [review]
Patch with the changes proposed by Walter

This seems to fix things. r=asa (for what that's worth).

Comment 4

[Simon Paquet [:sipaq]]

Asa, can you check this in?

Comment 5

[Alexander Mikhailian]

Does not work yet on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a)
Gecko/20021207 Phoenix/0.5

Comment 6

[Walter Wlodarski]

Influenced by bug 184360

Comment 7

[opmolf]

See bug "Query charset searching on dmoz.org does not match with which dmoz.org
expects", http://bugzilla.mozilla.org/show_bug.cgi?id=186819.

Comment 8

[Simon Paquet [:sipaq]]

*** Bug 188070 has been marked as a duplicate of this bug. ***

Comment 9

[Simon Paquet [:sipaq]]

*** Bug 194096 has been marked as a duplicate of this bug. ***

Comment 10

[Ervin Németh]

Attachment: Patch google.src to current version

Actually I've just looked at http://www.google.com/mozilla/google.src and it
was updated last October.  Here is the diff.  I think it should get synced.

Comment 11

[David Tenser [:djst]]

*** Bug 200770 has been marked as a duplicate of this bug. ***

Comment 12

[Robert Parenton]

Fixed checked in by jaggernaut.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/xpfe/components/search/datasets&command=DIFF_FRAMESET&file=google.src&rev1=1.2&rev2=1.3&root=/cvsroot
Should be marked as Resolved Fixed.

Comment 13

[Asa Dotzler [:asa]]

yep

Comment 14

[noririty]

query in japanese works well.
v.

Comment 15

[Simon Paquet [:sipaq]]

Taking QA Contact