Closed Bug 1806740 Opened 2 years ago Closed 1 year ago

Expose hasRuleForBrowsingContext in GeckoView

Categories

(GeckoView :: General, task, P1)

All
Android
task

Tracking

(firefox110 wontfix, firefox111 wontfix, firefox112 fixed)

RESOLVED FIXED
112 Branch
Tracking Status
firefox110 --- wontfix
firefox111 --- wontfix
firefox112 --- fixed

People

(Reporter: amejia, Assigned: owlish)

References

(Blocks 1 open bug)

Details

(Whiteboard: [cookie-banner] [geckoview:m111][geckoview:m112] [fxdroid] [foundation])

Attachments

(1 file)

No description provided.
Blocks: 1806741
Priority: -- → P2
Whiteboard: [cookie-banner] → [cookie-banner] [geckoview:m111]
Assignee: nobody → bugzeeeeee
Rank: 111
Severity: -- → N/A
Priority: P2 → P1
Pushed by istorozhko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d31a2cd2fc3c
Add API to expose hasRuleForBrowsingContext r=geckoview-reviewers,amejiamarmol,calu

Backed out for causing geckoview failures

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.GeckoSessionTestRuleTest#checkCookieBannerRuleForSession | java.lang.AssertionError: There should be a rule
Flags: needinfo?(bugzeeeeee)
Pushed by istorozhko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26c3fcaa9203
Add API to expose hasRuleForBrowsingContext r=geckoview-reviewers,amejiamarmol,calu

Backed out for causing Rules related gv-junit failures

Backout link

Push with failures

Failure log

Failure line: TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.GeckoSessionTestRuleTest#checkCookieBannerRuleForSession | java.lang.AssertionError: There should be a rule

Pushed by istorozhko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec733bc94063
Add API to expose hasRuleForBrowsingContext r=geckoview-reviewers,amejiamarmol,calu
Flags: needinfo?(bugzeeeeee)
Whiteboard: [cookie-banner] [geckoview:m111] → [cookie-banner] [geckoview:m111][geckoview:m112]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:owlish, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(calu)
Flags: needinfo?(bugzeeeeee)
Whiteboard: [cookie-banner] [geckoview:m111][geckoview:m112] → [cookie-banner] [geckoview:m111][geckoview:m112] [fxdroid] [foundation]
Pushed by istorozhko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e3c8167a7df6
Add API to expose hasRuleForBrowsingContext r=geckoview-reviewers,amejiamarmol,calu

Backed out for causing geckoview-junit-nofis failures in GeckoSessionTestRuleTest#checkCookieBannerRuleForSession

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.GeckoSessionTestRuleTest#checkCookieBannerRuleForSession | java.lang.AssertionError: There should be a rule
Flags: needinfo?(calu)
Pushed by istorozhko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a0e9a32199b
Add API to expose hasRuleForBrowsingContext r=geckoview-reviewers,amejiamarmol,calu

Backed out for causing gv-junit failures.

[task 2023-02-27T18:04:39.504Z] 18:04:39     INFO -  TEST-START | org.mozilla.geckoview.test.StorageControllerTest#clearDataFlags
[task 2023-02-27T18:04:43.465Z] 18:04:43     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: numtests=1013
[task 2023-02-27T18:04:43.465Z] 18:04:43     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stream=
[task 2023-02-27T18:04:43.465Z] 18:04:43     INFO -  org.mozilla.geckoview.test | Error in clearDataFlags(org.mozilla.geckoview.test.StorageControllerTest):
[task 2023-02-27T18:04:43.465Z] 18:04:43     INFO -  org.mozilla.geckoview.test | java.lang.AssertionError: Cookie value should match
[task 2023-02-27T18:04:43.465Z] 18:04:43     INFO -  org.mozilla.geckoview.test | Expected: "ctx=test"
[task 2023-02-27T18:04:43.466Z] 18:04:43     INFO -  org.mozilla.geckoview.test |      but: was "foo=bar; ctx=test"
[task 2023-02-27T18:04:43.466Z] 18:04:43     INFO -  org.mozilla.geckoview.test | 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
[task 2023-02-27T18:04:43.466Z] 18:04:43     INFO -  org.mozilla.geckoview.test | 	at org.junit.Assert.assertThat(Assert.java:956)
[task 2023-02-27T18:04:43.466Z] 18:04:43     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
[task 2023-02-27T18:04:43.466Z] 18:04:43     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
[task 2023-02-27T18:04:43.466Z] 18:04:43     INFO -  org.mozilla.geckoview.test | 	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
[task 2023-02-27T18:04:43.467Z] 18:04:43     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.checkThat(GeckoSessionTestRule.java:909)
[task 2023-02-27T18:04:43.467Z] 18:04:43     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.BaseSessionTest.assertThat(BaseSessionTest.kt:144)
[task 2023-02-27T18:04:43.467Z] 18:04:43     INFO -  org.mozilla.geckoview.test | 	at org.mozilla.geckoview.test.StorageControllerTest.clearDataFlags(StorageControllerTest.kt:117)
[task 2023-02-27T18:04:43.467Z] 18:04:43     INFO -  org.mozilla.geckoview.test |
<...>
[task 2023-02-27T18:04:44.096Z] 18:04:44     INFO -  02-27 18:04:42.743 D/GeckoViewConsole( 3471): onEvent GeckoView:WebExtension:PortMessageFromApp {"message":{"id":"bb0c5353-97d1-4fe7-b364-4e0b1f88e2d9","eval":"\n            document.cookie || 'null'\n        "}}
[task 2023-02-27T18:04:44.096Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): Error
[task 2023-02-27T18:04:44.096Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): java.lang.AssertionError: Cookie value should match
[task 2023-02-27T18:04:44.096Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): Expected: "ctx=test"
[task 2023-02-27T18:04:44.096Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471):      but: was "foo=bar; ctx=test"
[task 2023-02-27T18:04:44.097Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
[task 2023-02-27T18:04:44.097Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.junit.Assert.assertThat(Assert.java:956)
[task 2023-02-27T18:04:44.097Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
[task 2023-02-27T18:04:44.097Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
[task 2023-02-27T18:04:44.097Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
[task 2023-02-27T18:04:44.097Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule.checkThat(GeckoSessionTestRule.java:909)
[task 2023-02-27T18:04:44.098Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.mozilla.geckoview.test.BaseSessionTest.assertThat(BaseSessionTest.kt:144)
[task 2023-02-27T18:04:44.098Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.mozilla.geckoview.test.StorageControllerTest.clearDataFlags(StorageControllerTest.kt:117)
[task 2023-02-27T18:04:44.098Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at java.lang.reflect.Method.invoke(Native Method)
[task 2023-02-27T18:04:44.098Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
[task 2023-02-27T18:04:44.098Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
[task 2023-02-27T18:04:44.098Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
[task 2023-02-27T18:04:44.099Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
[task 2023-02-27T18:04:44.099Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.junit.rules.Verifier$1.evaluate(Verifier.java:35)
[task 2023-02-27T18:04:44.099Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2.lambda$evaluate$0$org-mozilla-geckoview-test-rule-GeckoSessionTestRule$2(GeckoSessionTestRule.java:1473)
[task 2023-02-27T18:04:44.099Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at org.mozilla.geckoview.test.rule.GeckoSessionTestRule$2$$ExternalSyntheticLambda0.run(D8$$SyntheticClass)
[task 2023-02-27T18:04:44.099Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:428)
[task 2023-02-27T18:04:44.099Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
[task 2023-02-27T18:04:44.100Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1950)
[task 2023-02-27T18:04:44.100Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at android.os.Handler.handleCallback(Handler.java:751)
[task 2023-02-27T18:04:44.100Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at android.os.Handler.dispatchMessage(Handler.java:95)
[task 2023-02-27T18:04:44.100Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at android.os.Looper.loop(Looper.java:154)
[task 2023-02-27T18:04:44.100Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at android.app.ActivityThread.main(ActivityThread.java:6077)
[task 2023-02-27T18:04:44.100Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at java.lang.reflect.Method.invoke(Native Method)
[task 2023-02-27T18:04:44.101Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:866)
[task 2023-02-27T18:04:44.101Z] 18:04:44     INFO -  02-27 18:04:42.748 E/GeckoSessionTestRule( 3471): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:756)
[task 2023-02-27T18:04:44.101Z] 18:04:44     INFO -  02-27 18:04:42.750 D/GeckoViewContent( 3471): handleEvent: DOMWindowClose
[task 2023-02-27T18:04:44.101Z] 18:04:44     INFO -  02-27 18:04:42.752 D/GeckoViewConsole( 3471): onEvent GeckoView:WebExtension:List null
[task 2023-02-27T18:04:44.101Z] 18:04:44     INFO -  02-27 18:04:42.755 E/GeckoSessionTestRule( 3471): test_end c5ee677f-bc83-49bd-9e28-2d35f3d0f059 clearDataFlags(org.mozilla.geckoview.test.StorageControllerTest)
[task 2023-02-27T18:04:44.101Z] 18:04:44  WARNING -  TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.StorageControllerTest#clearDataFlags | java.lang.AssertionError: Cookie value should match
[task 2023-02-27T18:04:44.101Z] 18:04:44     INFO -  TEST-INFO took 4570ms
[task 2023-02-27T18:04:44.102Z] 18:04:44     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: numtests=1013
[task 2023-02-27T18:04:44.102Z] 18:04:44     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: stream=
[task 2023-02-27T18:04:44.102Z] 18:04:44     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
[task 2023-02-27T18:04:44.102Z] 18:04:44     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: test=sessionContext
[task 2023-02-27T18:04:44.102Z] 18:04:44     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: class=org.mozilla.geckoview.test.StorageControllerTest
[task 2023-02-27T18:04:44.102Z] 18:04:44     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS: current=766
[task 2023-02-27T18:04:44.102Z] 18:04:44     INFO -  org.mozilla.geckoview.test | INSTRUMENTATION_STATUS_CODE: 1
[task 2023-02-27T18:04:44.103Z] 18:04:44     INFO -  TEST-START | org.mozilla.geckoview.test.StorageControllerTest#sessionContext
Flags: needinfo?(bugzeeeeee)
Flags: needinfo?(bugzeeeeee)
Flags: needinfo?(bugzeeeeee)
Pushed by istorozhko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc3bdd8c19f8
Add API to expose hasRuleForBrowsingContext r=geckoview-reviewers,amejiamarmol,calu
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch

Irene, does this fix need to be uplifted to Beta 111 for the CBH experiment planned for 111?

Flags: needinfo?(bugzeeeeee)

Chris, it looks like this API won't be needed for the experiment, so the answer is no.

Flags: needinfo?(bugzeeeeee)

Thanks. In that case, setting firefox111=wontfix.

Component: Core → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: