1806744 - Cleanup asmjs option processing in CompileOptions constructor

Status: NEW

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

This code is a mess and should be organized a bit better into checking:

1. ContextOptions: Both asmJS and wasmIon need to be available for deeper checks in IsAsmJSCompilationAvailable to pass, so make this explicit
2. Platform support: Check wasm::HasPlatformSupport and friends. Remove need for cx argument to this.
3. Debugger check: The asmjs and wasm debug flags got a bit tangled up, so keep checking both.

There is also a defect in current code where debugger being attached is observed as no compiler available instead of the explicit debugger message, so that should be fixed and a test case added.

Comment 1

[Bryan Thrall [:bthrall]]

Attachment: WIP: Bug 1806744 - Report asm.js failure message when debugging

js::IsAsmJSCompilationAvailable() indirectly checks if the debugger is active
(via wasm::IonDisabledByFeatures()), so the CompileOptions constructor was
setting asmJSOption to DisabledByNoWasmCompiler in some cases when it should be
DisabledByDebugger.

All cases for asmJSOption should be covered by the jit-tests now.