1806780 - 1.03 - 0.39% installer size / installer size + 2 more (OSX) regression on Sun December 18 2022

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[Alex Finder]

Perfherder has detected a build_metrics performance regression from push 7c000fcb98531f7b140dae59477ccd35554cbcd7. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
1%	installer size	osx-aarch64-shippable	aarch64 nightly	84,219,698.67 -> 85,084,765.00
1%	installer size	osx-shippable	nightly	86,284,747.25 -> 87,109,792.42
1%	installer size	osx-shippable	instrumented	121,949,481.33 -> 122,696,356.17
0.39%	installer size	osx-cross		82,968,506.50 -> 83,288,046.92

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1806166

Comment 2

[Jim Blandy :jimb]

This may be because bug 1806166 enabled the Vulkan back end for wgpu-core on Mac. In the version of wgpu-core Firefox was using prior to 1806166, wgpu-core/Cargo.toml did not enable Vulkan, but with 1806166 landed, gfx/wgpu_bindings/Cargo.toml does.

Comment 3

[Jim Blandy :jimb]

Attachment: Bug 1806780: Don't enable Vulkan WebGPU backend on OSX. r?teoxoy

Comment 4

[Jim Blandy :jimb]

try push

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d081cb1a99ca
Don't enable Vulkan WebGPU backend on OSX. r=teoxoy

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d081cb1a99ca

Comment 7

[Alex Finder]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d081cb1a99ca
Don't enable Vulkan WebGPU backend on OSX. r=teoxoy

== Change summary for alert #36660 (as of Fri, 30 Dec 2022 12:13:49 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
1%	installer size	osx-aarch64-shippable	aarch64 nightly	85,009,099.04 -> 84,160,828.92
1%	installer size	osx-shippable	nightly	87,146,689.83 -> 86,377,353.67
1%	installer size	osx-shippable	instrumented	122,706,883.46 -> 122,004,576.58

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36660