Last Comment Bug 180692 - enter_bug shows keywords option even if keywords are disabled
: enter_bug shows keywords option even if keywords are disabled
Status: RESOLVED FIXED
: regression
Product: Bugzilla
Classification: Server Software
Component: Creating/Changing Bugs (show other bugs)
: 2.17.1
: x86 Linux
: -- normal (vote)
: Bugzilla 2.18
Assigned To: Tobias Burnus
: default-qa
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2002-11-18 04:10 PST by Bradley Baetz (:bbaetz)
Modified: 2012-12-18 20:46 PST (History)
1 user (show)
justdave: approval+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Add a 'use_keywords' to vars. (1.66 KB, patch)
2003-02-27 02:28 PST, Tobias Burnus
bbaetz: review+
Details | Diff | Splinter Review
Add "@legal_keywords" to use vars qw(...) (427 bytes, patch)
2003-02-27 14:40 PST, Tobias Burnus
justdave: review+
Details | Diff | Splinter Review

Description Bradley Baetz (:bbaetz) 2002-11-18 04:10:51 PST
The bug entry page shows the option to add a keyword even if no keywords are
defined. It should check @::legal_keywords like the entry page does.
Comment 1 Tobias Burnus 2003-02-27 02:28:43 PST
Created attachment 115745 [details] [diff] [review]
Add a 'use_keywords' to vars.

This makes use of @::legal_keywords using the famous
  $vars->{'use_keywords'} = 1 if (@::legal_keywords);
(as long_list.cgi and buglist.cgi do).
Comment 2 Tobias Burnus 2003-02-27 02:31:13 PST
Did a patch - take the bug.
Comment 3 Tobias Burnus 2003-02-27 13:14:05 PST
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.80; previous revision: 1.79
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Comment 4 Dave Miller [:justdave] (justdave@bugzilla.org) 2003-02-27 14:13:44 PST
This patch broke the tree.

@::legal_keywords used only once in enter_bug.cgi

(do an additional checkin to fix it, that's a no-brainer)
Comment 5 Tobias Burnus 2003-02-27 14:40:25 PST
Created attachment 115799 [details] [diff] [review]
Add "@legal_keywords" to use vars qw(...)

One should really fix the "importxml.pl:" warning - I look at the logs thrice
and always I've missed that line.
Now writing this comment, I'm trying to find it again - now without success
(knowing that I just saw it, it's really strange!)

Hmm, well, this patch at least removes this warning: perl -Tc enter_bug.cgi
Name "main::legal_keywords" used only once: possible typo at enter_bug.cgi line
359.

Conclustion: Doing a perl -Tc never hurds, even if the patch works ok (as I
tested).
Comment 6 Dave Miller [:justdave] (justdave@bugzilla.org) 2003-02-27 14:41:37 PST
Comment on attachment 115799 [details] [diff] [review]
Add "@legal_keywords" to use vars qw(...)

r= justdave
a= justdave
Comment 7 Tobias Burnus 2003-02-27 14:45:49 PST
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.81; previous revision: 1.80
done

Note You need to log in before you can comment on or make changes to this bug.