The default bug view has changed. See this FAQ.

enter_bug shows keywords option even if keywords are disabled

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Creating/Changing Bugs
RESOLVED FIXED
15 years ago
4 years ago

People

(Reporter: bbaetz, Assigned: Tobias Burnus)

Tracking

({regression})

2.17.1
Bugzilla 2.18
x86
Linux
regression
Bug Flags:
approval +

Details

Attachments

(2 attachments)

(Reporter)

Description

15 years ago
The bug entry page shows the option to add a keyword even if no keywords are
defined. It should check @::legal_keywords like the entry page does.
(Assignee)

Comment 1

14 years ago
Created attachment 115745 [details] [diff] [review]
Add a 'use_keywords' to vars.

This makes use of @::legal_keywords using the famous
  $vars->{'use_keywords'} = 1 if (@::legal_keywords);
(as long_list.cgi and buglist.cgi do).
(Assignee)

Updated

14 years ago
Attachment #115745 - Flags: review?(bbaetz)
(Reporter)

Updated

14 years ago
Attachment #115745 - Flags: review?(bbaetz) → review+
(Assignee)

Comment 2

14 years ago
Did a patch - take the bug.
Assignee: myk → burnus
Target Milestone: --- → Bugzilla 2.18
(Assignee)

Updated

14 years ago
Flags: approval?
Flags: approval? → approval+
(Assignee)

Comment 3

14 years ago
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.80; previous revision: 1.79
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.16; previous revision: 1.15
done
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
This patch broke the tree.

@::legal_keywords used only once in enter_bug.cgi

(do an additional checkin to fix it, that's a no-brainer)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

14 years ago
Created attachment 115799 [details] [diff] [review]
Add "@legal_keywords" to use vars qw(...)

One should really fix the "importxml.pl:" warning - I look at the logs thrice
and always I've missed that line.
Now writing this comment, I'm trying to find it again - now without success
(knowing that I just saw it, it's really strange!)

Hmm, well, this patch at least removes this warning: perl -Tc enter_bug.cgi
Name "main::legal_keywords" used only once: possible typo at enter_bug.cgi line
359.

Conclustion: Doing a perl -Tc never hurds, even if the patch works ok (as I
tested).
(Assignee)

Updated

14 years ago
Attachment #115799 - Flags: review?
Comment on attachment 115799 [details] [diff] [review]
Add "@legal_keywords" to use vars qw(...)

r= justdave
a= justdave
Attachment #115799 - Flags: review? → review+
(Assignee)

Comment 7

14 years ago
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.81; previous revision: 1.80
done
Status: REOPENED → RESOLVED
Last Resolved: 14 years ago14 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.