Closed Bug 1806923 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 37640 - Revert "Reject getDisplayMedia calls without user activation"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox110 fixed)

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37640 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37640
Details from upstream follow.

Peter Williamson <petewil@chromium.org> wrote:

Revert "Reject getDisplayMedia calls without user activation"

This reverts commit 5fbd1e8cdadc327dedfad9ce896e24c562e59fbf.

Reason for revert: Reverted by Sheriff on suspicion of causing a test failure. https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/110084/test-results?sortby=&groupby=&q=ExactID%3Aninja%3A%2F%2F%3Ablink_wpt_tests%2Fexternal%2Fwpt%2Fscreen-capture%2Fpermissions-policy-audio%2Bvideo.https.sub.html+VHash%3A9f5ebdc6f73354e7.

The test failure lists getDisplayMedia failing as the cause, and this CL is in the blame set and looks related.

Original change's description:

Reject getDisplayMedia calls without user activation

This CL makes sure getDisplayMedia() returned promise reject with
InvalidStateError when called without user activation.
Note that speculation rules tests are updated as well[1].

[1] https://github.com/WICG/nav-speculation/issues/225

Intent to remove: https://groups.google.com/a/chromium.org/g/blink-dev/c/YGmuAVOqftI

Bug: 1198918
Change-Id: I530761d95e6db412582d0f19c0170803516c33f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4096797
Reviewed-by: Dale Curtis \<dalecurtis@chromium.org>
Reviewed-by: Hiroki Nakagawa \<nhiroki@chromium.org>
Reviewed-by: Elad Alon \<eladalon@chromium.org>
Commit-Queue: Fr \<beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1086033}

Bug: 1198918
Change-Id: I14d0e47ee406aa09b6eec763e94d8e83f282a04d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119423
Auto-Submit: Peter Williamson \<petewil@chromium.org>
Quick-Run: Peter Williamson \<petewil@chromium.org>
Commit-Queue: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Peter Williamson \<petewil@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1086147}

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL : 2
ERROR : 1

Chrome

OK : 2
PASS : 1
FAIL : 1
TIMEOUT: 1
ERROR : 1

Safari

OK : 2
FAIL : 2
ERROR : 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0e91b78b004a [wpt PR 37640] - Revert "Reject getDisplayMedia calls without user activation", a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.