1806936 - Intermittent STDOUT: SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/toolkit/components/url-classifier/Classifier.cpp:1791:10 in ShouldAbort

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Treeherder Bug Filer]

Filed by: rvandermeulen [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=400434058&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cm8dw35EQWGSTEH_Md8cwg/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Ran into this while getting the wdspec tests working in TSAN mode (bug 1806934).

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: tsan log

Comment 3

[Intermittent Failures Robot]

2 failures in 2999 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform and build breakdown:

• linux1804-64-tsan-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1806936&startday=2022-12-19&endday=2022-12-25&tree=all

Comment 4

[Intermittent Failures Robot]

2 failures in 1328 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1
• autoland: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1806936&startday=2022-12-26&endday=2023-01-01&tree=all

Comment 5

[Intermittent Failures Robot]

16 failures in 2607 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 6
• mozilla-central: 2
• try: 8

Platform and build breakdown:

• linux1804-64-tsan-qr: 16
  • opt: 16

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1806936&startday=2023-01-02&endday=2023-01-08&tree=all

Comment 6

[Tim Huang[:timhuang]]

Attachment: Bug 1806936 - Use Atomic on the mIsClosed in the Classifier. r?dimi!

This patch wrap the mIsClosed with Atomic to avoid race condition
between the main thread and the worker thread.

Comment 7

[Intermittent Failures Robot]

9 failures in 3530 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1
• autoland: 7
• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 9
  • opt: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1806936&startday=2023-01-09&endday=2023-01-15&tree=all

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6090ae19f68c
Use Atomic on the mIsClosed in the Classifier. r=dimi

Comment 9

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/6090ae19f68c

Comment 10

[Intermittent Failures Robot]

4 failures in 3717 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2
• mozilla-central: 1
• try: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1806936&startday=2023-01-16&endday=2023-01-22&tree=all

Comment 11

[Intermittent Failures Robot]

2 failures in 3914 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 2

Platform and build breakdown:

• linux1804-64-tsan-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1806936&startday=2023-01-23&endday=2023-01-29&tree=all

Comment 12

[Intermittent Failures Robot]

1 failures in 3643 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1806936&startday=2023-02-20&endday=2023-02-26&tree=all