firefox-android: Add separate meta entries for each of the monorepo project folder
Categories
(Localization Infrastructure and Tools :: General, defect)
Tracking
(Not tracked)
People
(Reporter: gl, Assigned: gl)
Details
We’re in a bit of weird state with android-l10n tooling - See slack thread, https://github.com/mozilla-l10n/android-l10n/pull/572 and https://github.com/mozilla-l10n/android-l10n/pull/574. I think the issue is quite easy to understand - we have 2 jobs (AC / Focus) that are looking for the last commit containing string changes in each of their folder and then importing a range commits into the android-l10n repo. Since the last commit will be different for each job, it’s gonna constantly go back and forth re-importing a range of commits because the recorded commit will always be ahead or behind for one of the jobs. However, this is not necessarily an issue because you will see in https://github.com/mozilla-l10n/android-l10n/pull/572 (the last AC commit with strings was Oct 24 vs Focus which was 3 days ago) that it is importing nothing since those commits have already been committed prior. This will create some issues in the short term for delphine because seeing a range of commits being imported is gonna appear alarming.
2 paths of investigation:
(1) Separate out _meta/mozilla-mobile-firefox-android.json into 2 different json files that tracks the commit sha for each of the folders (AC/Focus) - this should be easy, but no idea if this will really resolve things. Perhaps, just the fact that the job isn’t seeing that we need to update the commit sha in the json file will mean it won’t create a phantom PR with no changes to commit. We also want to remove the root level l10n.toml as well in the short term and clearly there is code that is acting on it despite the file not being used.
(2) Investigate a path where we just run 1 job that will import both Focus and AC simultaneously. This is admittedly a bigger(??) project or at least I don’t believe will be trivial.
We will go ahead with investigating option 1.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•1 year ago
•
|
||
|
|
Assignee | |
Updated•1 year ago
|
Description
•